Skip to content

Conversation

@yangcao77
Copy link
Collaborator

Signed-off-by: Stephanie [email protected]

What does this PR do?:

This PR pulls in latest devfile/api which includes the validation to resource requirement .

Which issue(s) this PR fixes:

Fixes devfile/api#672

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested a review from elsony November 18, 2021 17:08
@yangcao77 yangcao77 force-pushed the 685-resourcevalidation branch from 592d6f6 to 10144b3 Compare November 18, 2021 17:12
@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maysunfaisal, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [maysunfaisal,yangcao77]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2021
@yangcao77 yangcao77 merged commit 10738e7 into devfile:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Devfile validation does not verify that resource requests are less than resource limits.

2 participants