-
Notifications
You must be signed in to change notification settings - Fork 202
Include Typescript typings in published package #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should fix Typescript projects being unable to load the included typings.
|
Would be great to get this merged in. What are the next steps here? |
|
@bradleyayers Should be done, but not sure why the CI fails. Can @developit help us on this? Edit: Also, in the meantime, you can import the entirety of import 'isomorphic-unfetch' |
|
I've just thrown a temporary |
|
@resir014 tests failing on master, so it's not just your PR :) I think @developit is very busy. He's maintaining 100s of repos. @developit do you need another maintainer? Willing to help out. |
|
That might be a good idea! My github notifications are unrecoverable at this point TBH, though this repo shouldn't be much of a maintenance burden. If anyone wants to help out (I noticed @styfle and @DanielRuf doing a bunch of lovely work!) hit me up on the preact slack or Twitter and we'll set up collaborators. |
|
I haven't figured out what's up with the CI build, but there's no way this change is breaking so it's merge time. |
|
Things should be looking a little peachier now, spent an hour or two cleaning up and cut a 3.1.0 release. |
|
I'll take a look today probably and check what we can improve or make better and ensure more stable and faster CI jobs. |
|
The CI job is failing due to a missing space in the sanity check. I think this was / is already fixed in master (afaik). |
|
See #73. |
This should fix Typescript projects being unable to load the included typings.
Fixes #69, #64.