Skip to content

Conversation

@resir014
Copy link
Contributor

@resir014 resir014 commented Apr 30, 2018

This should fix Typescript projects being unable to load the included typings.

Fixes #69, #64.

This should fix Typescript projects being unable to load the included typings.
@bradleyayers
Copy link

Would be great to get this merged in. What are the next steps here?

@resir014
Copy link
Contributor Author

resir014 commented May 22, 2018

@bradleyayers Should be done, but not sure why the CI fails. Can @developit help us on this?

Edit: Also, in the meantime, you can import the entirety of isomorphic-unfetch in your entry point as a workaround.

import 'isomorphic-unfetch'

@bradleyayers
Copy link

I've just thrown a temporary declare module "unfetch"; for now, 🤞🏻this will be released soon. I came across it as this library is suggested by apollo-link-http when running under Jest.

@simonbuerger
Copy link
Contributor

@resir014 tests failing on master, so it's not just your PR :)

I think @developit is very busy. He's maintaining 100s of repos.

@developit do you need another maintainer? Willing to help out.

@developit
Copy link
Owner

That might be a good idea! My github notifications are unrecoverable at this point TBH, though this repo shouldn't be much of a maintenance burden. If anyone wants to help out (I noticed @styfle and @DanielRuf doing a bunch of lovely work!) hit me up on the preact slack or Twitter and we'll set up collaborators.

@developit developit merged commit 13a7577 into developit:master Jul 20, 2018
@developit
Copy link
Owner

I haven't figured out what's up with the CI build, but there's no way this change is breaking so it's merge time.

@developit
Copy link
Owner

Things should be looking a little peachier now, spent an hour or two cleaning up and cut a 3.1.0 release.

@DanielRuf
Copy link
Contributor

I'll take a look today probably and check what we can improve or make better and ensure more stable and faster CI jobs.

@DanielRuf
Copy link
Contributor

The CI job is failing due to a missing space in the sanity check.

I think this was / is already fixed in master (afaik).

@DanielRuf
Copy link
Contributor

See #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPM Types not working

5 participants