chore(editorconfig): add editorconfig #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
you cant add what you want. @developit has preferences, and for #19 i was kinda forced to add editorconfig, so i added editorconfig that he want and thought to add :) |
Owner
|
Hmm - here I thought I was being clever using Github's web interface to edit, and it basically overwrote yours. Hopefully that's not annoying, sorry! What you had was pretty close to what I usually use, just with some defaults moved around and a character set specified for JavaScript. The source for what I ammended is preact's editorconfig. Let me know if my changes are alright, didn't mean to trample there! |
Contributor
Author
|
Everything okay. 😄 I didn't know about the preact's editorconfig. But it makes sense to reuse the config. |
Owner
|
Cool! Time to merge then :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.