feat: Add Supabase integration with PgVector document store and embedding retriever #3164
feat: Add Supabase integration with PgVector document store and embedding retriever #3164pontuselmrin wants to merge 20 commits intodeepset-ai:mainfrom
Conversation
There was a problem hiding this comment.
Do we have to rename the file from document_store.py to pg_document_store.py the reason for the same is this issue makes use of SupabaseVectorBucketDocumentStore. Hence the question.
cc @davidsbatista
There was a problem hiding this comment.
I think its a good idea to wait for this one to be merged. I already scaffolded the integration so I think it could simplify the workflow for you a bit. @srini047
There was a problem hiding this comment.
Yes, that's what even I think orelse the effort gets duplicated here. So only my question on file naming remains.
There was a problem hiding this comment.
let's first merge this one - it's already in a very good state, just a few things need being addressed
…ectorDocumentStore
|
@pontuselmrin I did a first review and pushed some adjustments and fixed a few issues. But, overall, the PR looks pretty good! Just some small improvements to complete it, and it should be ready to go:
Let me know if you have any questions/doubts |
Related Issues
SupabasePgVectorDocumentStoreandSupabasePgvectorEmbeddingRetriever#3081Proposed Changes:
How did you test it?
The testing functionality is done using a Supabase instance but because the feature is wrapping the pgvector integration the tests are essentially lifted from there.
Notes for the reviewer
Tested on Mac OS and Supabase CLI run via Docker locally.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.