fix(router): ensure Traefik dashboard port is always bound to localhost #7942
+86
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request:
See Testing a PR.
|
rfay
approved these changes
Dec 17, 2025
Member
There was a problem hiding this comment.
I tested this manually with both router-bind-all-interfaces=true and false, and it did the right thing. The code is right. I didn't carefully examine the test, but it looked right.
I tested access to the port(s) using telnet, and looked at ~/.ddev/.router-compose-full.yaml to confirm that it was right.
rfay
changed the title
Member
|
@JUVOJustin I note that the Traefik dashboard can also be turned off in Traefik (It's enabled in ~/.ddev/traefik/.static_config.yaml). Another useful approach would be to disable that completely on publicly accessible systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the traefik dashboard is exposed with port 10999 to be publically accessible if
router_bind_all_interfaces=true. This can leak information when ddev is used for public hosting.How This PR Solves The Issue
The PR binds the port only to localhost.
Manual Testing Instructions
makerouter_bind_all_interfaces=truegloballyI also installed this dev branch on my public host machine and validated that the port is actually not exposed to the public anymore.
Automated Testing Overview
The new test checks the port binding in the docker composer and tries if the dashboard can still be accessed locally.
Release/Deployment Notes
No breaking changes as far as i can tell. The traefik rest api can still be accessed from the host.
curl 127.0.0.1:10999/api/versionwould still work.