Skip to content

ufal/show-no-spinner-when-item-has-no-files #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 6 commits into from
Jul 10, 2025
Merged

ufal/show-no-spinner-when-item-has-no-files #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
22907c6
show msg about no files when item has no files, show no spinenr
Paurikova2 Jul 8, 2025
e5f4a6d
check if files are array
Paurikova2 Jul 8, 2025
e78a57b
check files size
Paurikova2 Jul 8, 2025
155ff77
fix error
Paurikova2 Jul 8, 2025
eacfd21
optimize template with hasNoFiles flag
Paurikova2 Jul 9, 2025
0a3f32c
used behaviourSubject for hasNoFiles / aynchronous
Paurikova2 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions src/app/item-page/simple/field-components/preview-section/preview-section.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,24 @@
<!-- Loading Spinner -->
<div *ngIf="(listOfFiles | async)?.length === 0" class="d-flex flex-column justify-content-center align-items-center my-3">
<div class="spinner-border text-primary" role="status"></div>
<div class="px-4 pt-2">{{'item.preview.loading-files' | translate}}
<a *ngIf="emailToContact" [href]="'mailto:' + emailToContact" class="email-text">{{ emailToContact }}</a>
<ng-container *ngIf="(listOfFiles | async) as files; else loading">
<!-- Show "No files" message -->
<div *ngIf="(hasNoFiles | async)" class="text-center text-muted my-3">
{{ 'item.view.box.no-files.message' | translate }}
</div>
</div>
<div *ngFor="let file of (listOfFiles | async)">
<ds-file-description [fileInput] = 'file'></ds-file-description>
</div>

<!-- Show list of files -->
<div *ngFor="let file of files">
<ds-file-description [fileInput]="file"></ds-file-description>
</div>
</ng-container>

<!-- Spinner shown only while listOfFiles is null or undefined -->
<ng-template #loading>
<div class="d-flex flex-column justify-content-center align-items-center my-3">
<div class="spinner-border text-primary" role="status"></div>
<div class="px-4 pt-2">
{{ 'item.preview.loading-files' | translate }}
<a *ngIf="emailToContact" [href]="'mailto:' + emailToContact" class="email-text">
{{ emailToContact }}
</a>
</div>
</div>
</ng-template>
4 changes: 2 additions & 2 deletions src/app/item-page/simple/field-components/preview-section/preview-section.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export class PreviewSectionComponent implements OnInit {

listOfFiles: BehaviorSubject<MetadataBitstream[]> = new BehaviorSubject<MetadataBitstream[]>([] as any);
emailToContact: string;
hasNoFiles: BehaviorSubject<boolean> = new BehaviorSubject<boolean>(true);

constructor(protected registryService: RegistryService,
private configService: ConfigurationDataService) {} // Modified
Expand All @@ -26,11 +27,10 @@ export class PreviewSectionComponent implements OnInit {
.pipe(getAllSucceededRemoteListPayload())
.subscribe((data: MetadataBitstream[]) => {
this.listOfFiles.next(data);
this.hasNoFiles.next(!Array.isArray(data) || data.length === 0);
});
this.configService.findByPropertyName('lr.help.mail')?.subscribe(remoteData => {
this.emailToContact = remoteData.payload?.values?.[0];
});
}


}