Merged
Conversation
* Created Creative Common license view for the Item Page view * Corrected grammar mistakes, updated hover animation for cc icons * Removed debug method and improved performance
…1009) * Fixed still loading of the `Saving` bar for the CC licenses * Removed unnecessary files
There was a problem hiding this comment.
Pull Request Overview
This PR implements Creative Commons (CC) license support functionality by cherry-picking features from multiple upstream pulls. It adds license detection, display, and submission handling for items.
- Adds internationalization support for CC license display text
- Implements a new CreativeCommonsLicenseFieldComponent for displaying CC licenses on item pages
- Enhances the submission component with debounced CC license updates and better state management
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/assets/i18n/en.json5 | Adds English translations for CC license labels and descriptions |
| src/assets/i18n/cs.json5 | Adds Czech translations for CC license labels and descriptions |
| src/app/submission/sections/cc-license/submission-section-cc-licenses.component.ts | Implements debounced license updates and improved state management |
| src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html | Integrates CC license field display |
| src/app/item-page/simple/item-types/publication/publication.component.html | Integrates CC license field display |
| src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.ts | Main CC license detection and display logic |
| src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.spec.ts | Comprehensive test suite for CC license component |
| src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.scss | Styling for CC license display |
| src/app/item-page/simple/field-components/creative-commons-license-field/creative-commons-license-field.component.html | Template for CC license display with icons |
| src/app/item-page/item-page.module.ts | Module registration for new component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…w the placeholder
milanmajchrak
requested changes
Nov 6, 2025
Collaborator
milanmajchrak
left a comment
milanmajchrak
left a comment
There was a problem hiding this comment.
Did you run sync messages tool?
src/app/item-page/simple/item-types/publication/publication.component.html
Outdated
Show resolved
Hide resolved
src/app/item-page/simple/item-types/untyped-item/untyped-item.component.html
Outdated
Show resolved
Hide resolved
…quest-dev/dspace-angular into ufal/cherrypick-cc-license
milanmajchrak
approved these changes
Nov 6, 2025
Collaborator
Author
|
I have replied on the previous comment |
|
@milanmajchrak resolve comments if you are happy with them |
vidiecan
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Cherry-pick of new features: CC license
pull/1011
pull/1009
pull/966