Skip to content

Test first touch#4

Closed
milanmajchrak wants to merge 16 commits intodtq-devfrom
test-first-touch
Closed

Test first touch#4
milanmajchrak wants to merge 16 commits intodtq-devfrom
test-first-touch

Conversation

@milanmajchrak
Copy link
Collaborator

@milanmajchrak milanmajchrak commented Mar 30, 2022

Phases MM MB Total
ETA 4 0 0
Developing 4 0 0
Review 0 0 0
Total - - 0
ETA est. 0
ETA cust. - - 0

Problem description

Reported issues

Not-reported issues

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
  • My PR passes Checkstyle validation based on the Code Style Guide.
  • My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
  • My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
  • If my PR includes new, third-party dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR modifies the REST API, I've linked to the REST Contract page (or open PR) related to this change.

@milanmajchrak milanmajchrak requested a review from vidiecan March 30, 2022 13:55
@milanmajchrak milanmajchrak self-assigned this Mar 30, 2022
[![Build](https://github.com/dataquest-dev/DSpace/actions/workflows/build.yml/badge.svg)](https://github.com/dataquest-dev/DSpace/actions/workflows/build.yml)
[![codecov](https://codecov.io/gh/dataquest-dev/DSpace/branch/dtq-dev/graph/badge.svg?token=YI6CJNFI2H)](https://codecov.io/gh/dataquest-dev/DSpace)

## Overview
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you duplicate readme contents?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, it shouldn't be here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied whole content because for each point could be added additional information. I would like to keep the content from README.md.

README.md Outdated

* Backend (this codebase) provides a REST API, along with other machine-based interfaces (e.g. OAI-PMH, SWORD, etc)
* The REST Contract is at https://github.com/DSpace/RestContract
* The REST Contract is at https://github.com/DSpace/RestContract
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

import org.dspace.content.service.WorkspaceItemService;
import org.junit.Test;

public class ItemIT extends AbstractIntegrationTestWithDatabase {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation ?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand, what with documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added

import org.junit.Test;
import org.springframework.beans.factory.annotation.Autowired;

public class CommunityExampleIT extends AbstractControllerIntegrationTest {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs added

@vidiecan
Copy link

vidiecan commented Apr 6, 2022

@milanmajchrak should this PR be really merged?

@milanmajchrak
Copy link
Collaborator Author

@vidiecan I created another pull request for README-dtq.md file #36. I would like to cancel this PR.

@MajoBerger MajoBerger deleted the test-first-touch branch March 1, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants