Skip to content

UFAL/Cherrypick feature for editing actual dspace config files#1108

Merged
milanmajchrak merged 25 commits intodtq-devfrom
ufal/cherrypick-feature-for-editing-actual-dspace-config-files
Jan 13, 2026
Merged

UFAL/Cherrypick feature for editing actual dspace config files#1108
milanmajchrak merged 25 commits intodtq-devfrom
ufal/cherrypick-feature-for-editing-actual-dspace-config-files

Conversation

@jr-rk
Copy link

@jr-rk jr-rk commented Oct 2, 2025

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Cherry-pick of new features: feature for editing actual dspace config files
pull/1097

Kasinhou and others added 2 commits October 2, 2025 11:55
* Added czech email templates

* Updated some translations

---------

Co-authored-by: Matus Kasak <matus.kasak@dataquest.sk>
…#1097)

* Created feature for editing actual dspace configuration files

* Fixed Doc and removed unused class

* Fixed unit tests
@jr-rk jr-rk requested review from Copilot and milanmajchrak October 2, 2025 10:07
@jr-rk jr-rk self-assigned this Oct 2, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Cherry-picks a feature to enable editing of selected DSpace configuration files via an admin-only REST API, and adds Czech email templates.

  • Adds a ConfigFileService with validation, backup, and read/write operations, and exposes it via new REST endpoints under /api/admin/configfiles.
  • Introduces integration and unit tests for the new service and controller.
  • Adds multiple Czech-language email templates and a new property in dspace.cfg to whitelist updateable config files.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
dspace/config/emails/welcome_cs New Czech welcome email template.
dspace/config/emails/share_submission_cs New Czech share-submission email template.
dspace/config/emails/request_item.rejected_cs New Czech request-item rejected email template.
dspace/config/emails/request_item.granted_cs New Czech request-item granted email template.
dspace/config/emails/request_item.admin_cs New Czech admin notification for open access request.
dspace/config/emails/healthcheck_cs New Czech healthcheck email template.
dspace/config/emails/doi_maintenance_error_cs New Czech DOI maintenance error email template.
dspace/config/emails/clarin_download_link_cs New Czech download link email template.
dspace/config/emails/clarin_download_link_admin_cs New Czech admin notification for download request.
dspace/config/emails/clarin_autoregistration_cs New Czech auto-registration confirmation email template.
dspace/config/emails/batch_import_success_cs New Czech batch import success email template.
dspace/config/emails/batch_import_error_cs New Czech batch import error email template.
dspace/config/dspace.cfg Adds ORCID feature include and whitelist of updateable files.
dspace-server-webapp/src/test/java/org/dspace/app/rest/ConfigFileRestControllerIT.java Integration tests for config files REST endpoints.
dspace-server-webapp/src/main/java/org/dspace/app/rest/model/hateoas/ConfigFileResource.java HAL resource wrapper for ConfigFileRest.
dspace-server-webapp/src/main/java/org/dspace/app/rest/model/ConfigFileRest.java REST model for config file metadata.
dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/*.java REST-layer exception types (annotated with @ResponseStatus).
dspace-server-webapp/src/main/java/org/dspace/app/rest/converter/ConfigFileConverter.java Converter from model to HAL resource.
dspace-server-webapp/src/main/java/org/dspace/app/rest/ConfigFileRestController.java Admin REST controller for listing, reading, and updating config files.
dspace-api/src/test/java/org/dspace/app/configuration/service/ConfigFileServiceImplTest.java Unit tests for ConfigFileServiceImpl.
dspace-api/src/main/java/org/dspace/app/configuration/service/ConfigFileServiceImpl.java Service implementation for config file operations with validation and backups.
dspace-api/src/main/java/org/dspace/app/configuration/service/ConfigFileService.java Service interface and metadata container.
dspace-api/src/main/java/org/dspace/app/configuration/exception/*.java Service-layer exception types.
Comments suppressed due to low confidence (3)

dspace/config/emails/doi_maintenance_error_cs:1

  • The subject uses ${params[3]} (resource id) where the parameters specify {4} as the DOI; replace ${params[3]} with ${params[4]} to include the DOI in the subject.
## E-mail sent to designated address when a metadata update, registration

dspace/config/emails/clarin_download_link_cs:1

  • The header documents {4} as helpdesk phone number, but the template reads the phone from configuration instead of params[4]. Either use ${params[4]} or update the parameter documentation to reflect that the phone is sourced from configuration.
## E-mail with a download link

dspace/config/emails/clarin_autoregistration_cs:1

  • The header documents {2} as helpdesk phone number, but the template pulls the phone from configuration. Either switch to ${params[2]} or adjust the documented parameters for accuracy.
## E-mail sent to confirm authenticity of the user's e-mail.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@milanmajchrak milanmajchrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Copilot
  2. Checks are red

@jr-rk
Copy link
Author

jr-rk commented Nov 12, 2025

checks are red because of the cherry-picked VŠB commit e580272
Many integration tests are failing @milanmajchrak

@milanmajchrak milanmajchrak merged commit 119a95b into dtq-dev Jan 13, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants