You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.
In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.
I don't have much knowledge in which cases we run these tests, but I assume these tests should run for any branches.
Hence shouldn't this script run tests for master too? (even though we publish on main)
No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.
No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.
so do I understand correctly that this scripts run only when we publish from main?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.