Skip to content

Branch name from master to main#1853

Merged
Tuseeq1 merged 1 commit intomainfrom
build_fix
Sep 30, 2024
Merged

Branch name from master to main#1853
Tuseeq1 merged 1 commit intomainfrom
build_fix

Conversation

@Tuseeq1
Copy link
Member

@Tuseeq1 Tuseeq1 commented Sep 30, 2024

In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.

@DiasDauletov
Copy link
Contributor

In GCB the default branch name used is master while we check on main to publish. This also makes more sense since we use main everywhere else as default branch.

I don't have much knowledge in which cases we run these tests, but I assume these tests should run for any branches.
Hence shouldn't this script run tests for master too? (even though we publish on main)

@Tuseeq1
Copy link
Member Author

Tuseeq1 commented Sep 30, 2024

No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.

@DiasDauletov
Copy link
Contributor

No this change is only for publishing the npm package and does not affect any other tests or builds. Master does not exist anywhere else other than GCB for some reason they are still using master instead of main. We publish only from main branch.

so do I understand correctly that this scripts run only when we publish from main?

@Tuseeq1
Copy link
Member Author

Tuseeq1 commented Sep 30, 2024

yes

@Tuseeq1 Tuseeq1 merged commit 83afdbe into main Sep 30, 2024
@Tuseeq1 Tuseeq1 deleted the build_fix branch September 30, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants