Update Data Preparation processor to remove proto dependency. #1839
Merged
Update Data Preparation processor to remove proto dependency. #1839
Conversation
…a preparation in the compiled graph now contains the resolved YAML after compiling.
Ekrekr
approved these changes
Sep 11, 2024
| definition.nodes.forEach((node, index) => { | ||
| // Loop through all nodes and resolve the compilation overrides for | ||
| // all source and destination tables. | ||
| if (definition.nodes) { |
Contributor
There was a problem hiding this comment.
Note that definition.nodes isn't guaranteed to be present, so this may throw a weird error to the user if they fill out the YAML wrong
Collaborator
Author
There was a problem hiding this comment.
Should I try catching any errors here and then rethrowing with an error message mentioning that the YAML is invalid?
Contributor
|
(Fix tests before merge plz) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data preparation in the compiled graph now contains the resolved YAML after compiling.
I will remove the proto reference in a follow up PR.