Skip to content

Fix notebook dependency targets#1792

Merged
Ekrekr merged 8 commits intomainfrom
fix-notebook-dependency-targets
Aug 7, 2024
Merged

Fix notebook dependency targets#1792
Ekrekr merged 8 commits intomainfrom
fix-notebook-dependency-targets

Conversation

@Ekrekr
Copy link
Copy Markdown
Contributor

@Ekrekr Ekrekr commented Jul 30, 2024

Some fixes are:

  • Notebooks can properly be dependency targets of other targets, by hacking from "location" to "dataset" fields.
  • Notebooks, views and incremental tables now correctly convert dependency targets to compiled graph targets.
  • Better type safeness by extracting configs proto target conversion and action configs proto conversion to separate functions.

@Ekrekr Ekrekr requested a review from GJMcGowan July 30, 2024 11:27
@Ekrekr Ekrekr requested a review from chemerisuk August 5, 2024 08:35
Copy link
Copy Markdown

@chemerisuk chemerisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ekrekr Ekrekr merged commit 1c188e4 into main Aug 7, 2024
@Ekrekr Ekrekr deleted the fix-notebook-dependency-targets branch August 7, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants