feat: vscode extension, more intutive compile errors#1775
Merged
Ekrekr merged 3 commits intodataform-co:mainfrom Jul 9, 2024
Merged
feat: vscode extension, more intutive compile errors#1775Ekrekr merged 3 commits intodataform-co:mainfrom
Ekrekr merged 3 commits intodataform-co:mainfrom
Conversation
Ekrekr
approved these changes
Jul 8, 2024
Contributor
Ekrekr
left a comment
Ekrekr
left a comment
There was a problem hiding this comment.
Much nicer!
You need to merge from this repo's main I think, have just merged some other PRs.
vscode/server.ts
Outdated
| } | ||
|
|
||
| async function compileAndValidate() { | ||
| let hasCompilationError = false; |
Contributor
There was a problem hiding this comment.
This is a bit confusingly named, because the errors below are also compilation errors. A better name would probably be let compilationFailed = false
Contributor
Author
There was a problem hiding this comment.
Thanks @Ekrekr, I agree. I have made the suggested change and synced this branch with dataform repo's main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the default behaviour for when a compilation error occurs is to show a generic information message. The PR uses the graphErrors object and outputs the errors to the user similar to GCP Dataform UI
Current behaviour
New behaviour