Add interactive profile picker to auth logout by mihaimitrea-db · Pull Request #4616 · databricks/cli

mihaimitrea-db · 2026-02-27T14:50:43Z

🥞 Stacked PR

Use this link to review incremental changes.

stack/auth_logout [Files changed]
- stack/auth_logout_profile_picker [Files changed]
  - stack/auth_logout_deduplication [Files changed]

When --profile is not specified in an interactive terminal, show a searchable prompt listing all configured profiles. Profiles are sorted alphabetically and displayed with their host or account ID. The picker supports fuzzy search by name, host, or account ID.

Changes

When --profile is omitted in an interactive terminal, show a searchable prompt listing all configured profiles sorted alphabetically. Profiles display their host or account ID, and support fuzzy search by name, host, or account ID.
Expand the command's long help text to document all four interaction modes (explicit --profile, interactive picker, non-interactive error, --force).

Tests

Existing unit tests from #4613 continue to pass (profile picker is only triggered in interactive mode, which tests mock as non-interactive).
Manual testing with multiple profiles to verify picker display, search, and selection.

eng-dev-ecosystem-bot · 2026-02-27T15:01:22Z

Commit: 4bd2e44

Run: 22722758124

	Env	🪲BUG	❌FAIL	🟨KNOWN	🔄flaky	💚RECOVERED	🙈SKIP	✅pass	🙈skip	Time
💚	aws linux					8	7	268	786	9:47
💚	aws windows					8	7	270	784	7:02
🔄	aws-ucws linux				2	7	7	364	701	14:32
🔄	aws-ucws windows				2	7	7	366	699	10:47
🪲	azure linux	1	8	1		1	9	262	784	146:27
🪲	azure windows	1	8	1		1	9	264	782	132:07
🪲	azure-ucws linux	1	8	1	2	1	9	359	697	149:20
🪲	azure-ucws windows	1	8	1	2		9	362	695	148:41
🪲	gcp linux	1	8	1		1	9	258	787	146:15
🪲	gcp windows	1	8	1		1	9	260	785	123:13

26 interesting tests: 8 FAIL, 7 SKIP, 6 RECOVERED, 3 flaky, 1 KNOWN, 1 BUG

	Test Name	aws linux	aws windows	aws-ucws linux	aws-ucws windows	azure linux	azure windows	azure-ucws linux	azure-ucws windows	gcp linux	gcp windows
🟨	TestAccept	💚R	💚R	🔄f	🔄f	🟨K	🟨K	🟨K	🟨K	🟨K	🟨K
🪲	TestAccept/bundle/deployment/bind/alert	🙈s	🙈s	🙈s	🙈s	🪲B	🪲B	🪲B	🪲B	🪲B	🪲B
❌	TestAccept/bundle/deployment/bind/alert/DATABRICKS_BUNDLE_ENGINE=direct					❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/deployment/bind/alert/DATABRICKS_BUNDLE_ENGINE=terraform					❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/generate/alert	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/generate/alert/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/generate/alert/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/resources/alerts/with_file	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/resources/alerts/with_file/DATABRICKS_BUNDLE_ENGINE=direct	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
❌	TestAccept/bundle/resources/alerts/with_file/DATABRICKS_BUNDLE_ENGINE=terraform	✅p	✅p	✅p	✅p	❌F	❌F	❌F	❌F	❌F	❌F
🙈	TestAccept/bundle/resources/permissions	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions	💚R	💚R	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions	💚R	💚R	💚R	💚R	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct	💚R	💚R	💚R	💚R
💚	TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform	💚R	💚R	💚R	💚R
🙈	TestAccept/bundle/resources/postgres_branches/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/recreate	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/update_protected	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_branches/without_branch_id	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/postgres_endpoints/recreate	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🙈	TestAccept/bundle/resources/synced_database_tables/basic	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S	🙈S
🔄	TestAccept/ssh/connect-serverless-gpu	🙈s	🙈s	🔄f	🔄f	🙈s	🙈s	🔄f	🔄f	🙈s	🙈s
🔄	TestAccept/ssh/connection	💚R	💚R	💚R	💚R	💚R	💚R	💚R	🔄f	💚R	💚R
🔄	TestFetchRepositoryInfoAPI_FromRepo	✅p	✅p	✅p	✅p	✅p	✅p	🔄f	✅p	✅p	✅p

Top 21 slowest tests (at least 2 minutes):

duration	env	testname
5:36	aws-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
5:19	aws-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
5:11	aws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
4:54	aws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
4:42	aws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
4:32	aws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:54	gcp windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:48	gcp windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:43	aws-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:42	aws-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:33	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:26	gcp linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:19	azure-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:18	azure-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
3:07	azure-ucws linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
3:04	azure linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform
2:40	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:36	azure-ucws windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:26	aws linux	TestAccept
2:23	azure linux	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=direct
2:16	azure windows	TestAccept/bundle/resources/apps/inline_config/DATABRICKS_BUNDLE_ENGINE=terraform

simonfaltum

Looks good! I left some comments

cmd/auth/logout.go

cmd/auth/logout_test.go

cmd/auth/logout.go

libs/databrickscfg/ops.go

cmd/auth/logout.go

simonfaltum · 2026-03-02T22:42:58Z

cmd/auth/logout.go

+	slices.SortFunc(allProfiles, func(a, b profile.Profile) int {
+		return strings.Compare(strings.ToLower(a.Name), strings.ToLower(b.Name))
+	})


do we always sort profiles alphabetically? I'd think we just want to show them in the order they were added (or alternatively last used or most used but we don't log that anywhere..)

My personal preference is to have lists sorted, but you are right, no other picker in the codebase does this so for consistency let's go wth the order in which they were added.

simonfaltum · 2026-03-02T22:50:30Z

cmd/auth/logout.go

+// promptForLogoutProfile shows an interactive profile picker for logout.
+// Account profiles are displayed as "name (account: id)", workspace profiles
+// as "name (host)".
+func promptForLogoutProfile(ctx context.Context, profiler profile.Profiler) (string, error) {


I think this is good work but did you look through the codebase for similar patterns?
I think the closest existing pattern is promptForProfileSelection in cmd/auth/token.go (line ~368), which already handles an "all profiles" picker with search by name/host and the StartInSearchMode: len(profiles) > 5 pattern.
I think we are re-implementing much of this logic, which maybe is justified but it might be worth it to make a component we could re-use broadly as selecting profile interactively is something we will have to do multiple times. I think in auth token it lets you create a new profile also, which is probably not something we want to do in logout 😃

I tried fixing that in the next PR on this stack. Check that out: #4647

Replace manual strings.TrimRight(host, /) with the SDK's config.Config.CanonicalHostName(), which handles scheme normalization, trailing slashes, and empty hosts consistently with how the SDK itself computes token cache keys.

- Make Long description static to avoid calling logger and GetPath at command construction time before the logger is initialized. - Remove empty test.toml files from acceptance tests. - Add \n to error-case titles so errors appear on a separate line. - Use .tokens | keys in jq queries for token cache to reduce verbosity. - Switch test profiles from PAT to auth_type=databricks-cli (U2M) so token cache tests exercise a realistic OAuth logout flow. - Add AuthType field to profile.Profile to detect non-U2M profiles; skip token cache cleanup and adjust success message accordingly. - Add delete-m2m-profiles acceptance test covering PAT profile logout with and without --delete. - Fix DeleteProfile to clear DEFAULT section keys instead of deleting and recreating it, preserving its position in the file.

- Rename isU2MProfile to isCreatedByLogin to accurately reflect that the check is specific to profiles created by . - Tighten success and error messages: drop "Successfully", add actionable suggestions (e.g. "Use --delete to also remove it"), and include retry guidance on partial failures. - Return errors instead of logging on DeleteProfile failure so callers see a non-zero exit code. - Fix token-only acceptance test: use OIDC-style cache key (host/oidc/accounts/<id>) for account profiles so both token cache entries are correctly cleaned up.

When --profile is not specified in an interactive terminal, show a searchable prompt listing all configured profiles. Profiles are sorted alphabetically and displayed with their host or account ID. The picker supports fuzzy search by name, host, or account ID.

Document the four interaction modes (explicit profile, interactive picker, non-interactive error, and --force) in the command's long help text.

mihaimitrea-db mentioned this pull request Feb 27, 2026

Add auth logout command with --profile and --force flags #4613

Open

mihaimitrea-db temporarily deployed to test-trigger-is February 27, 2026 14:51 — with GitHub Actions Inactive

mihaimitrea-db requested a review from simonfaltum February 27, 2026 15:01

simonfaltum reviewed Feb 27, 2026

View reviewed changes

mihaimitrea-db self-assigned this Mar 2, 2026

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch 2 times, most recently from f374e5a to c903ed8 Compare March 2, 2026 11:42

mihaimitrea-db temporarily deployed to test-trigger-is March 2, 2026 11:42 — with GitHub Actions Inactive

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from c903ed8 to 889b7ca Compare March 2, 2026 12:11

mihaimitrea-db temporarily deployed to test-trigger-is March 2, 2026 12:12 — with GitHub Actions Inactive

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from 889b7ca to 7a39778 Compare March 2, 2026 12:45

mihaimitrea-db temporarily deployed to test-trigger-is March 2, 2026 12:45 — with GitHub Actions Inactive

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from 7a39778 to 67eff3f Compare March 2, 2026 13:27

mihaimitrea-db temporarily deployed to test-trigger-is March 2, 2026 13:28 — with GitHub Actions Inactive

mihaimitrea-db linked an issue Mar 2, 2026 that may be closed by this pull request

[Feature] Add logout command #1639

Open

mihaimitrea-db marked this pull request as ready for review March 2, 2026 14:07

mihaimitrea-db requested review from andrewnester, anton-107, denik, pietern and shreyas-goenka as code owners March 2, 2026 14:07

mihaimitrea-db requested a review from simonfaltum March 2, 2026 14:07

mihaimitrea-db temporarily deployed to test-trigger-is March 2, 2026 14:07 — with GitHub Actions Inactive

simonfaltum reviewed Mar 2, 2026

View reviewed changes

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from a87d5a2 to bcf6e70 Compare March 3, 2026 12:30

mihaimitrea-db requested review from a team and lennartkats-db as code owners March 3, 2026 12:30

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from bcf6e70 to e536cc8 Compare March 3, 2026 12:37

mihaimitrea-db added 5 commits March 5, 2026 13:52

Improve profile list when specified profile does not exist

3de4b00

Fix failing acceptance test

229ba37

Fix failing tests due to wrong context

865c3b0

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout branch from d5746db to 865c3b0 Compare March 5, 2026 13:53

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from c6a2f23 to 3c8e18a Compare March 5, 2026 13:53

mihaimitrea-db temporarily deployed to test-trigger-is March 5, 2026 13:53 — with GitHub Actions Inactive

mihaimitrea-db changed the base branch from mihaimitrea-db/stack/auth_logout to main March 5, 2026 13:54

mihaimitrea-db changed the base branch from main to mihaimitrea-db/stack/auth_logout March 5, 2026 13:55

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from 3c8e18a to c37cac0 Compare March 5, 2026 14:08

mihaimitrea-db temporarily deployed to test-trigger-is March 5, 2026 14:08 — with GitHub Actions Inactive

Fix failing test

aa2fd40

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from c37cac0 to 6a3a446 Compare March 5, 2026 14:19

mihaimitrea-db temporarily deployed to test-trigger-is March 5, 2026 14:20 — with GitHub Actions Inactive

mihaimitrea-db temporarily deployed to test-trigger-is March 5, 2026 14:30 — with GitHub Actions Inactive

mihaimitrea-db added 6 commits March 5, 2026 14:32

Update acceptance tests to match new terminal outputs

25dca58

Expand auth logout long description with usage details

6e8d5bd

Document the four interaction modes (explicit profile, interactive picker, non-interactive error, and --force) in the command's long help text.

Update command description to reflect the introduction of --delete flag

3998830

Improve auth logout long description wording

866ff96

Remove profile picker list sorting

4bd2e44

mihaimitrea-db force-pushed the mihaimitrea-db/stack/auth_logout_profile_picker branch from 369f620 to 4bd2e44 Compare March 5, 2026 14:32

mihaimitrea-db temporarily deployed to test-trigger-is March 5, 2026 14:33 — with GitHub Actions Inactive

mihaimitrea-db marked this pull request as ready for review March 5, 2026 14:46

mihaimitrea-db changed the base branch from mihaimitrea-db/stack/auth_logout to main March 5, 2026 15:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add interactive profile picker to auth logout#4616

Add interactive profile picker to auth logout#4616
mihaimitrea-db wants to merge 24 commits intomainfrom
mihaimitrea-db/stack/auth_logout_profile_picker

mihaimitrea-db commented Feb 27, 2026 •

edited

Loading

Uh oh!

eng-dev-ecosystem-bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

simonfaltum left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simonfaltum Mar 2, 2026

Uh oh!

mihaimitrea-db Mar 5, 2026

Uh oh!

simonfaltum Mar 2, 2026

Uh oh!

mihaimitrea-db Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mihaimitrea-db commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🥞 Stacked PR

Changes

Tests

Uh oh!

eng-dev-ecosystem-bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonfaltum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simonfaltum Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

mihaimitrea-db Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

simonfaltum Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

mihaimitrea-db Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mihaimitrea-db commented Feb 27, 2026 •

edited

Loading

eng-dev-ecosystem-bot commented Feb 27, 2026 •

edited

Loading