add appName field to DartDevelopmentServiceConfiguration#2811
Merged
add appName field to DartDevelopmentServiceConfiguration#2811
Conversation
jakemac53
changed the title
github-actions
bot
added
the
type-infra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These app names are ultimately passed to
DartDevelopmentServiceLauncher.start, which forwards them along when registering the VmService to DTD. There is a default ofUnknown web appwhen this configuration is missing, which at least provides some information to clients, even if an explicit app name is not passed, we know it is some web application.Ultimately, this means that when agents (or tools) connect to a DTD instance and list the applications, they have a description of what the app actually is.
This will be used by flutter web and webdev, to report information about the running application for use by DTD clients.
The DDS version has also been increased, as that is required for the new
appNameparameter.Note: I did initially include the webdev implementation bits but stripped them out due to the dwds move into the SDK, we should wait to land that until a new version of dwds is published to avoid needing dependency overrides.