Conversation
Closes #1614 Use should be replaced by the edge browser. It has been 2 years since we removed support for internet explorer in dart2js. We have not been testing internet explorer integration, and it may already be broken by dart2js changes. Remove every reference to `ie` or internet explorer in the repo. Treat this as non-breaking for `package:test` even though there is a small risk of breaking some users still using internet explorer and it happens to still be working.
|
There is a usage of the Runtime constant in flutter engine. flutter/engine#46592 will move them to edge which is a better fit. It's unfortunate to need a major version bump for this - I wonder if we can get away with eagerly fixing the flutter usage and then treating it as non-breaking. WDYT @jakemac53 ? Or maybe we can drop the support in |
|
I would be fine with leaving it around but just dropping support. Can we mark it deprecated? |
Yes, after cleaning up flutter's usage. |
|
Currently this is set up to land before the publish in #2156, but we shouldn't consider it a blocker for publishing. |
|
Lets go ahead and merge this prior to the publish |
2 participants
Closes #1614
Use should be replaced by the edge browser.
It has been 2 years since we removed support for internet explorer in
dart2js. We have not been testing internet explorer integration, and it
may already be broken by dart2js changes.
Remove every reference to
ieor internet explorer in the repo.Treat this as non-breaking for
package:testeven though there is asmall risk of breaking some users still using internet explorer and it
happens to still be working.