Skip to content

Progress so far #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dakersnar wants to merge 43 commits into
base: ieee-decimal-PRed
Choose a base branch
from
Open

Progress so far #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
053c7a3
Add IDecimalFloatingPointIEE754 and Decimal32
dakersnar Nov 15, 2022
dcf9ca4
fix initial Decimal32 surface, fix ref files
dakersnar Nov 16, 2022
543bf3d
Automatic updates to sln and projitems files
dakersnar Nov 16, 2022
6bba90b
Merge branch 'main' of https://github.com/dotnet/runtime into ieee-de…
dakersnar Dec 5, 2022
19c0463
Making progress
dakersnar Dec 9, 2022
142221d
Started fleshing out IeeeDecimalNumber.cs
dakersnar Dec 15, 2022
0c592f2
More progress including Parse and TryParse
dakersnar Dec 15, 2022
e60fbfa
continue to work on parsing
dakersnar Dec 16, 2022
474cdcb
Make AllowHyphenDuringParsing public
dakersnar Dec 19, 2022
88bb570
Merge branch 'main' of https://github.com/dotnet/runtime into ieee-de…
dakersnar Dec 19, 2022
c327401
Fix csproj file to include IeeeDecimalNumber.cs
dakersnar Dec 19, 2022
faf39b4
remove methods
dakersnar Dec 19, 2022
b6a36f8
Start with Number.NumberToFloatingPointBits.cs copy
dakersnar Dec 19, 2022
39cbf41
Oops, forgot to add this file. This is the start of the work on the N…
dakersnar Dec 19, 2022
d1d9a7f
Stopping point for parsing, moving to formatting first
dakersnar Dec 20, 2022
3967c80
Just kidding, continuing to work on parsing. I think this is complete.
dakersnar Dec 21, 2022
e7a86c1
Fix exception throwing in parsing
dakersnar Dec 21, 2022
70e493c
Add missing parsing elements
dakersnar Dec 21, 2022
2c72ff7
Fill out Decimal32 constructor
dakersnar Dec 21, 2022
61611be
add Decimal32Tests.cs
dakersnar Dec 21, 2022
2e55401
Undo accidental sln change
dakersnar Dec 21, 2022
b910176
Finish parsing end to end
dakersnar Dec 23, 2022
8e03769
30 out of 48 parse tests passing
dakersnar Dec 27, 2022
ecbb04c
33 out of 48 parse tests passing
dakersnar Dec 27, 2022
1030ea6
51/51 Parse Tests Pass
dakersnar Dec 27, 2022
25488b8
All parse tests passing
dakersnar Dec 27, 2022
57ce295
Better test coverage for parsing stuff
dakersnar Dec 27, 2022
3656aaa
Cleanup
dakersnar Dec 28, 2022
0ba0672
more cleanup
dakersnar Dec 28, 2022
a48d274
Merge pull request #1 from dakersnar/ieee-decimal-basic-setup-and-par…
dakersnar Dec 28, 2022
549cc0f
Organized Decimal32.cs
dakersnar Jan 21, 2023
1691996
Rename the parsing file
dakersnar Jan 21, 2023
bea1d8a
move helper
dakersnar Jan 21, 2023
08590c2
Merge pull request #2 from dakersnar/ieee-decimal-cleanup-APIs
dakersnar Jan 21, 2023
20ae1bf
Fixed ref file
dakersnar Jan 21, 2023
04607f6
Add Lerp, comment out Platinum functions and interfaces
dakersnar Jan 27, 2023
b921150
Add conversions
dakersnar Jan 27, 2023
d1f3ffe
Address PR feedback
dakersnar Jan 27, 2023
35c1665
Move IDecimalFloatingPointIee754.cs, update ref files
dakersnar Jan 27, 2023
5842c4b
Add Encode* and Decode* functions
dakersnar Feb 3, 2023
8f8d4c2
Small update on interface
dakersnar Feb 3, 2023
0c3bb82
slight adjustments
dakersnar Feb 6, 2023
a394ddc
Adjust constant name
dakersnar Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/coreclr/System.Private.CoreLib/System.Private.CoreLib.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.28902.138
# Visual Studio Version 17
VisualStudioVersion = 17.4.32818.431
MinimumVisualStudioVersion = 10.0.40219.1
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Private.CoreLib", "System.Private.CoreLib.csproj", "{3DA06C3A-2E7B-4CB7-80ED-9B12916013F9}"
EndProject
Expand All @@ -9,10 +9,6 @@ EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "System.Private.CoreLib.Generators", "..\..\libraries\System.Private.CoreLib\gen\System.Private.CoreLib.Generators.csproj", "{7196828B-5E00-4BC6-9A1E-492C948E41A3}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
..\..\libraries\System.Private.CoreLib\src\System.Private.CoreLib.Shared.projitems*{3da06c3a-2e7b-4cb7-80ed-9b12916013f9}*SharedItemsImports = 5
..\..\libraries\System.Private.CoreLib\src\System.Private.CoreLib.Shared.projitems*{845c8b26-350b-4e63-bd11-2c8150444e28}*SharedItemsImports = 13
EndGlobalSection
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Checked|amd64 = Checked|amd64
Checked|Any CPU = Checked|Any CPU
Expand Down Expand Up @@ -95,4 +91,7 @@ Global
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {DA05075A-7CDA-4F65-AF6A-CB5DB6CF936F}
EndGlobalSection
GlobalSection(SharedMSBuildProjectFiles) = preSolution
..\..\libraries\System.Private.CoreLib\src\System.Private.CoreLib.Shared.projitems*{845c8b26-350b-4e63-bd11-2c8150444e28}*SharedItemsImports = 13
EndGlobalSection
EndGlobal
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/NumberFormatInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ private static void VerifyDigitSubstitution(DigitShapes digitSub, string propert
}

internal bool HasInvariantNumberSigns => _hasInvariantNumberSigns;
internal bool AllowHyphenDuringParsing => _allowHyphenDuringParsing;
public bool AllowHyphenDuringParsing => _allowHyphenDuringParsing;
Copy link
Owner Author

@dakersnar dakersnar Jan 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a hack for the prototype. Another strategy is likely needed.


private void InitializeInvariantAndNegativeSignFlags()
{
Expand Down
10 changes: 7 additions & 3 deletions src/libraries/System.Runtime.Numerics/System.Runtime.Numerics.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
Microsoft Visual Studio Solution File, Format Version 12.00

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 17
VisualStudioVersion = 17.4.32818.431
MinimumVisualStudioVersion = 10.0.40219.1
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TestUtilities", "..\Common\tests\TestUtilities\TestUtilities.csproj", "{A22876CA-76C0-4ABD-8658-C2B3DFDFE537}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "LibraryImportGenerator", "..\System.Runtime.InteropServices\gen\LibraryImportGenerator\LibraryImportGenerator.csproj", "{55FC83C5-F34D-4B4B-BEAE-497DD5653BCE}"
Expand Down Expand Up @@ -61,12 +65,12 @@ Global
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{A22876CA-76C0-4ABD-8658-C2B3DFDFE537} = {A80D3604-A8C8-4B23-B0D3-316E46CFE60A}
{2C4CBA2D-4C9D-4B83-85A4-2DF75C91B0FC} = {A80D3604-A8C8-4B23-B0D3-316E46CFE60A}
{55FC83C5-F34D-4B4B-BEAE-497DD5653BCE} = {94F2DDDF-A2DA-4F69-9613-A92D50D84A1C}
{57EC916C-15B4-46BB-AE68-B4CD8BC7076C} = {94F2DDDF-A2DA-4F69-9613-A92D50D84A1C}
{C91AC3B4-647B-4D7F-83CA-BE90FFFC8CF3} = {18C5FB7C-2DE7-4BED-BA2B-53776E78E1E5}
{DB1922E9-EC35-44AC-9677-277B7D00595F} = {18C5FB7C-2DE7-4BED-BA2B-53776E78E1E5}
{91F8FBEF-C085-4542-BEE4-22449D80734A} = {F6066198-D324-499F-BEB7-55DF39460AB4}
{2C4CBA2D-4C9D-4B83-85A4-2DF75C91B0FC} = {A80D3604-A8C8-4B23-B0D3-316E46CFE60A}
{DB1922E9-EC35-44AC-9677-277B7D00595F} = {18C5FB7C-2DE7-4BED-BA2B-53776E78E1E5}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {B7C7E4C6-78B9-4AE7-AC8B-4F08EAD0DECB}
Expand Down
201 changes: 199 additions & 2 deletions src/libraries/System.Runtime.Numerics/ref/System.Runtime.Numerics.cs
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions src/libraries/System.Runtime.Numerics/src/System.Runtime.Numerics.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<RootNamespace>System.Numerics</RootNamespace>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
</PropertyGroup>
<ItemGroup>
<Compile Include="System\Numerics\Decimal32.cs" />
<Compile Include="System\Numerics\IDecimalFloatingPointIeee754.cs" />
<Compile Include="System\Numerics\IeeeDecimalNumber.Parsing.cs" />
<Compile Include="System\ThrowHelper.cs" />
<Compile Include="System\Numerics\BigIntegerCalculator.AddSub.cs" />
<Compile Include="System\Numerics\BigIntegerCalculator.DivRem.cs" />
Expand All @@ -22,12 +25,9 @@
<Compile Include="Properties\InternalsVisibleTo.cs" />
</ItemGroup>
<ItemGroup>
<Compile Include="$(CommonPath)System\Globalization\FormatProvider.Number.cs"
Link="System\Globalization\FormatProvider.Number.cs" />
<Compile Include="$(CommonPath)System\Text\ValueStringBuilder.cs"
Link="CoreLib\System\Text\ValueStringBuilder.cs" />
<Compile Include="$(CommonPath)System\HexConverter.cs"
Link="Common\System\HexConverter.cs" />
<Compile Include="$(CommonPath)System\Globalization\FormatProvider.Number.cs" Link="System\Globalization\FormatProvider.Number.cs" />
<Compile Include="$(CommonPath)System\Text\ValueStringBuilder.cs" Link="CoreLib\System\Text\ValueStringBuilder.cs" />
<Compile Include="$(CommonPath)System\HexConverter.cs" Link="Common\System\HexConverter.cs" />
</ItemGroup>
<ItemGroup>
<Reference Include="System.Memory" />
Expand Down
Loading