Skip to content

Add Etag header to response#547

Merged
jimlambie merged 1 commit intodevelopfrom
feature/etag-support
Apr 15, 2019
Merged

Add Etag header to response#547
jimlambie merged 1 commit intodevelopfrom
feature/etag-support

Conversation

@jimlambie
Copy link
Copy Markdown
Contributor

Close #546

This PR adds an ETag header to all GET responses, and returns a 304 if the hash of a response matches a request's If-None-Match header.

It also upgrades the ParseComments library to remove a vulnerability.

@jimlambie jimlambie requested a review from eduardoboucas April 11, 2019 13:22
Copy link
Copy Markdown
Contributor

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jimlambie jimlambie merged commit 2fec9aa into develop Apr 15, 2019
@jimlambie jimlambie deleted the feature/etag-support branch April 15, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Etag support

2 participants