The 5.3.0 source package is broken and doesn't include all required source files

[bording]

It looks like the 5.3.0 version of the FastExpressionCompiler.Internal.src package is missing a file that is required to let the code compile.

Taking a quick look at the package and repo, it appears that it's missing ILReader.cs.

I don't use FastExpressionCompiler.LightExpression.src, but it looks like there are problems with it also.

[dadhi]

Thanks for the find. Will fix sooon.

[sebastienros]

Maybe there is a way to detect these with a validation step in the deployment process?

[sebastienros]

@dadhi just a friendly reminder that we could use a new release with this fix in case it slipped your mind.

[dadhi]

Noted.

[dadhi]

@sebastienros v5.3.1 with the fix is released for src packages.

[bording]

@dadhi 5.3.1 is also broken, in a new way. Looks like you also included TestTools.cs in the package and it doesn't set all of the types to internal:

error CS0051: Inconsistent accessibility: parameter type 'AssertKind' is less accessible than method 'TestFailure.TestFailure(string, int, AssertKind, string)'
error CS0051: Inconsistent accessibility: parameter type 'AssertKind' is less accessible than method 'TestFailure.Deconstruct(out string, out int, out AssertKind, out string)'

TestFailure and TestStats are public instead of internal.

However, TestTools.cs shouldn't be part of the package at all, though. I don't want to compile testing code into my project assembly.

[sebastienros]

Maybe there is a way to detect these with a validation step in the deployment process?

Would you need help with this? I know the repository is not really standard in the way it's handling testing, GH workflows and PR validation. If you have thoughts though...