Conversation
Fil
approved these changes
Oct 1, 2021
Member
There was a problem hiding this comment.
LGTM. If we ever want to add a ties option, and the accessor as a string (#189),
the API would then become:
d3.rank(iterable[, accessor[, ties]])
(i.e. no ties without an accessor).
(Another possibility would be to name different methods: d3.rankOrder, etc.)
mbostock
added a commit
that referenced
this pull request
Oct 1, 2021
* only implement “low” ties strategy * only test “low” ties strategy * only allow iterables * adopt Float64Array.of * documentation: remove ties; observablehq/@d3/rank Co-authored-by: Philippe Rivière <fil@rezo.net>
mbostock
added a commit
that referenced
this pull request
Oct 1, 2021
* rank * only implement “low” ties strategy (#236) * only implement “low” ties strategy * only test “low” ties strategy * only allow iterables * adopt Float64Array.of * documentation: remove ties; observablehq/@d3/rank Co-authored-by: Philippe Rivière <fil@rezo.net> * not an iterator * main * tweak tests Co-authored-by: Mike Bostock <mbostock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.