Merged
Conversation
pokey
reviewed
May 30, 2022
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Thanks for the doc update! Super important stuff. Left a bunch of minor comments
Will-Sommers
commented
May 31, 2022
| return { | ||
| **get_lists( | ||
| ["scope_type", "selection_type", "subtoken_scope_type"], | ||
| ["scope_type", "selection_type", "subtoken_scope_type", "head_tail"], |
Collaborator
Author
There was a problem hiding this comment.
Not sure I like this but thinking of a better description...
Member
There was a problem hiding this comment.
I think this will have broken with merger of #672. We now have one list called something like simple_modifier that includes "head", "tail" and a few other things
Will-Sommers
changed the title
pokey
reviewed
Jun 8, 2022
| return { | ||
| **get_lists( | ||
| ["scope_type", "selection_type", "subtoken_scope_type"], | ||
| ["scope_type", "selection_type", "subtoken_scope_type", "head_tail"], |
Member
There was a problem hiding this comment.
I think this will have broken with merger of #672. We now have one list called something like simple_modifier that includes "head", "tail" and a few other things
docs/user/README.md
Outdated
|
|
||
| ##### `"block"` | ||
|
|
||
| The `"block"` modifier expands to above and below the target to select lines until an empty line is reached. |
Member
There was a problem hiding this comment.
Suggested change
| The `"block"` modifier expands to above and below the target to select lines until an empty line is reached. | |
| The `"block"` modifier expands above and below the target to select lines until an empty line is reached. |
pokey
previously approved these changes
Aug 17, 2022
pokey
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open to suggestion, just thought I'd add some of these in.
Closes: #698