Introduce tree-sitter queries for syntactic scopes#629
Introduce tree-sitter queries for syntactic scopes#629pokey merged 25 commits intocursorless-dev:mainfrom
Conversation
|
Shouldn't we use https://github.com/nvim-treesitter/tree-sitter-query instead of scheme? |
|
Also worth mentioning https://marketplace.visualstudio.com/items?itemName=jrieken.vscode-tree-sitter-query, which defines a language id for tree sitter queries |
|
sg! |
pokey
left a comment
There was a problem hiding this comment.
Just publishing a few random comments here
pokey
left a comment
There was a problem hiding this comment.
nice progress 😊. Definitely pretty clean / readable syntax. Left a few nits
pokey
left a comment
There was a problem hiding this comment.
Haven't read whole PR yet but here's some comments
|
As discussed in meet-up, algorithm is as follows:
|
772442c to
f775401
Compare
f775401 to
ecaf27f
Compare
|
Ok this one is good to go, but unfortunately it breaks "every funk" for Ruby. I created #1430 to fix that issue. That PR is ready, so would be great if you could have a look when you get a minute. I think they should prob merge in together so we don't break "every funk" in Ruby on main |
- Adds `@_.domain`, `@_.leading`, `@_.trailing`, `@_.removal`, and `@_.interior` tree-sitter query captures - Introduces `@_.iteration` tree-sitter query capture to allow indicating iteration scope for tree-sitter scope handlers - Depends on #629 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
Todo
iterationScope? That's the only thing that is a regression here.