Changed order surrounding pair lists were combined for spoken scope forms#2658
Merged
AndreasArvidsson merged 2 commits intomainfrom Sep 10, 2024
Merged
Changed order surrounding pair lists were combined for spoken scope forms#2658AndreasArvidsson merged 2 commits intomainfrom
AndreasArvidsson merged 2 commits intomainfrom
Conversation
phillco
approved these changes
Sep 10, 2024
cursorless-bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
…orms (#2658) I have a on purpose conflict where I have `string: doubleQuotes` pair and `string: string` scope. This allows me to do `string wrap` that will do double quotes, but `take string` should be all strings not just double quotes. This worked fine before the dfa optimization where we flattened the scope types in #2628 Just rearranging the lists so the one with scope types has higher priority than the list of wrappers fixes this. ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a on purpose conflict where I have
string: doubleQuotespair andstring: stringscope. This allows me to dostring wrapthat will do double quotes, buttake stringshould be all strings not just double quotes. This worked fine before the dfa optimization where we flattened the scope types in #2628Just rearranging the lists so the one with scope types has higher priority than the list of wrappers fixes this.
Checklist