Bugfixes: past token, past end of, subtoken out of range, sort tokens#229
Merged
AndreasArvidsson merged 18 commits intomasterfrom Aug 15, 2021
Merged
Bugfixes: past token, past end of, subtoken out of range, sort tokens#229AndreasArvidsson merged 18 commits intomasterfrom
AndreasArvidsson merged 18 commits intomasterfrom
Conversation
AndreasArvidsson
changed the title
AndreasArvidsson
changed the title
AndreasArvidsson
changed the title
pokey
reviewed
Aug 14, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Ok nice fixes; left a few comments tho. Also would be good to add a test with same initial state as "take token past trap" (eg cursor in middle of first token), but say "take past trap" to make sure it doesn't expand to first token. Could see us messing that one up down the road if there's no test 😅
pokey
approved these changes
Aug 15, 2021
Member
pokey
left a comment
pokey
left a comment
There was a problem hiding this comment.
Pushed a couple changes but otherwise looks good to me!
|
|
||
| public getTokenForRange(range: Range) { | ||
| return Object.values(this.map).find( | ||
| public getTokenSelectionForSelection( |
Member
There was a problem hiding this comment.
This code doesn't really fit in the navigation map. Earmarking to move it for cursorless engine 2.0 work, as it should become a proper scope type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #221
fixes #222
fixes #201
fixes #209
fixes #200
fixes #198