Skip to content

Support marketplace purchase event#45

Merged
kvanbere merged 1 commit intocuedo:masterfrom
AlistairB:marketplace-purchase-event
Oct 3, 2021
Merged

Support marketplace purchase event#45
kvanbere merged 1 commit intocuedo:masterfrom
AlistairB:marketplace-purchase-event

Conversation

@AlistairB
Copy link
Copy Markdown
Contributor

@AlistairB AlistairB commented Oct 3, 2021 •
edited
Loading

Issue reference:

Closes #46

Submission Checklist:

  • Have you followed the guidelines in our Contributing document (for example, is your tree a clean merge)?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission build?
  • Does your submission pass tests?
  • Have you run lints on your code locally prior to submission?
  • Have you updated all of the cabal/nix infrastructure?
  • Is this a breaking change? Have you discussed this?

@AlistairB AlistairB force-pushed the marketplace-purchase-event branch 3 times, most recently from 7bb64df to 3768a41 Compare October 3, 2021 03:44
kvanbere
kvanbere reviewed Oct 3, 2021
View reviewed changes
Comment thread src/GitHub/Data/Webhooks/Payload.hs Outdated
import qualified Data.Text as T
import Data.Vector (Vector)
import GHC.Generics (Generic)
import Data.Vector.Fusion.Util (Id)
Copy link
Copy Markdown
Member

@kvanbere kvanbere Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Copy link
Copy Markdown
Contributor Author

@AlistairB AlistairB Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops. The PR is very WIP, I'll let you know once it is ready for review. Thanks :)

@kvanbere
Copy link
Copy Markdown
Member

kvanbere commented Oct 3, 2021 •
edited
Loading

Thanks for the PR, happy to merge once the implementation is complete and marketplacePurchaseEventFixture is fixed to a valid fixture result 😄

@AlistairB AlistairB force-pushed the marketplace-purchase-event branch 2 times, most recently from cc8393b to 9d1659b Compare October 3, 2021 08:40
@AlistairB AlistairB force-pushed the marketplace-purchase-event branch from 9d1659b to 5f1c50a Compare October 3, 2021 08:47
@AlistairB AlistairB marked this pull request as ready for review October 3, 2021 08:48
@AlistairB
Copy link
Copy Markdown
Contributor Author

AlistairB commented Oct 3, 2021 •
edited
Loading

@kvanbere should be good now! Let me know if its needs any changes.

kvanbere
kvanbere approved these changes Oct 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kvanbere kvanbere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contributing high quality code.

@kvanbere kvanbere merged commit fcbf48f into cuedo:master Oct 3, 2021
@kvanbere
Copy link
Copy Markdown
Member

kvanbere commented Oct 3, 2021

I will make a 0.16.0 release a priority. There has not been a new release in some time, and it would be good to get these changes on Stackage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvanbere kvanbere kvanbere approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support marketplace purchase event

2 participants

@AlistairB @kvanbere