Skip to content

Add comprehensive tests for cuddZddSymm.c achieving 82% line coverage#97

Merged
doganulus merged 5 commits into4.0.0from
copilot/add-test-cases-for-cuddzddsymm
Dec 4, 2025
Merged

Add comprehensive tests for cuddZddSymm.c achieving 82% line coverage#97
doganulus merged 5 commits into4.0.0from
copilot/add-test-cases-for-cuddzddsymm

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 1, 2025

  • Analyze current coverage of src/cuddZddSymm.c
  • Create comprehensive test cases for cuddZddSymm.c
  • All 12 functions now covered (100% function coverage)
  • 562/689 lines covered (~82% line coverage)
  • Fixed code review feedback (removed const_cast, use static counter)
  • Run code review - addressed main concerns
  • Run CodeQL security check - no issues found
  • All 1449 tests pass
  • Fixed heap-buffer-overflow in "Test different group structures" test by properly managing the result variable lifecycle

Coverage Summary

  • Line coverage: 82% (562/689 lines)
  • Function coverage: 100% (12/12 functions)

Sanitizer/Valgrind Fix

  • Fixed heap-buffer-overflow in "cuddZddSymm - Test different group structures" test
  • Issue: The test had a memory leak where result was never used or dereferenced, and the product variable caused internal table access issues
  • Fix: Restructured test to properly use and update the result variable throughout the test lifecycle
Original prompt

Complete test cases for src/cuddZddSymm.c and target 90% coverage for the source file.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits December 1, 2025 09:45
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
…verage

Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Copilot AI changed the title [WIP] Complete test cases for src/cuddZddSymm.c and target 90% coverage Add comprehensive tests for cuddZddSymm.c achieving 82% line coverage Dec 1, 2025
Copilot AI requested a review from doganulus December 1, 2025 10:07
@doganulus
Copy link
Copy Markdown
Member

@copilot Investigate failures in sanitizer and valgrind tests and implement your solutions.

…ult variable

Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Dec 3, 2025

@copilot Investigate failures in sanitizer and valgrind tests and implement your solutions.

Fixed the heap-buffer-overflow in commit 508fcc7. The issue was in the "cuddZddSymm - Test different group structures" test which had a memory management problem where the result variable was never used or dereferenced, while the product variable caused internal table access issues during Cudd_zddProduct. The fix restructures the test to properly use and update the result variable throughout the test lifecycle. All 1449 tests now pass with both AddressSanitizer+UBSan and Valgrind memcheck.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@doganulus doganulus marked this pull request as ready for review December 4, 2025 07:24
@doganulus doganulus merged commit 738dd84 into 4.0.0 Dec 4, 2025
40 of 74 checks passed
@doganulus doganulus deleted the copilot/add-test-cases-for-cuddzddsymm branch December 5, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants