Add comprehensive tests for cuddApa.c (83.3% coverage)#82
Merged
Conversation
Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
…umbers Co-authored-by: doganulus <1174212+doganulus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test cases to achieve 90% coverage for cuddApa
Add comprehensive tests for cuddApa.c (83.3% coverage)
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test coverage for the Arbitrary Precision Arithmetic (APA) module. Coverage increased from 17.3% to 83.3%.
Changes
29 test cases covering all exported APA functions:
Cudd_ApaAdd,Cudd_ApaSubtract,Cudd_ApaShortDivision,Cudd_ApaIntDivision,Cudd_ApaShiftRightCudd_ApaCompare,Cudd_ApaCompareRatiosCudd_ApaPrintHex,Cudd_ApaPrintDecimal,Cudd_ApaStringDecimal,Cudd_ApaPrintExponentialCudd_ApaCountMinterm,Cudd_ApaPrintMinterm,Cudd_ApaPrintMintermExp,Cudd_ApaPrintDensityEdge cases tested: carry propagation, borrow handling, multi-digit arithmetic, rounding in exponential printing, complemented BDD nodes
Coverage Gap (90% not achievable)
The remaining 53 uncovered lines are defensive error handling:
fprintfEOF returns (~10 lines)Cudd_ApaPrintExponential(1 line)These require mocking infrastructure not available in Catch2.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.