Conversation
| } | ||
| ] | ||
| ], | ||
| "plugins": ["add-module-exports"] |
There was a problem hiding this comment.
This was needed because Babel 6 (and thus 7) no longer transform to module.exports by default. So in order to maintain current API this plugin was needed.
| "templateStrings": true, | ||
| "unicodeCodePointEscapes": true, | ||
| "jsx": true | ||
| "parser": "babel-eslint", |
There was a problem hiding this comment.
Only structure/formatting changes in this file. ESLint threw errors with the old config.
| "test": "mocha --compilers js:babel/register", | ||
| "prepublish": "rm -rf lib/* && npm run build" | ||
| "test": "mocha -r @babel/register", | ||
| "prepublishOnly": "rm -rf lib/* && npm run build" |
There was a problem hiding this comment.
The "prepublish" hook is deprecated
| @@ -1,7 +1,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
This is all that changed given the new dependency set!
|
Travis is failing because new Mocha/whatever doesn't run on Nodes 4 and 6. I set this up to support a patch release – so that we can resolve this dependency hell ASAP. Please let me know which so that I can adjust the test runner accordingly. |
|
Sorry for pings, but this has been a problem for nearly 2 years. Please let me know how to next proceed. @evilebottnawi @geelen @joshgillies @joshwnj @markdalgleish @michael-ciniawsky @Outpunk @sokra @sullenor @TrySound |
|
Unfortunately, I only have permissions for the postcss-modules repo. Actually, I'm quite frustrated because of the state of the CSS Modules family and thinking of rewriting postcss-modules to not use any deps. It's much easier to maintain a library that doesn't depend on unmaintained libraries. But this is a big amount of work, and I don't use postcss-modules myself. So I'm not sure if I should rewrite or maintain it at all. |
|
@Outpunk Yes, my initial mission was to rebuild Reworking I'm not aware of permissions – I just pinged everyone in the |
|
@lukeed let's do this another way — by copy-pasting the |
|
@lukeed working on it madyankin/postcss-modules#108 |
|
Agree, let's focus on |
|
Awesome :) thanks @Outpunk ! |
This package is seriously outdated, and it's causing a noticeable hiccup when installing
postcss-modules. Analysis below:This PR updates all dependencies to their latest semver ranges.
It also updates your devDependencies which were seriously outdated too.
It's actually pretty impressive that despite 5 dependencies loading new major versions, the only difference was with newline placements in the most complex test case. 👏
Closes #231, #234, #233, #24