Fix lint errors and enforced consistency#19
Open
rtsao wants to merge 1 commit intocss-modules:masterfrom
rtsao:fix-lint
Open
Fix lint errors and enforced consistency#19rtsao wants to merge 1 commit intocss-modules:masterfrom rtsao:fix-lint
rtsao wants to merge 1 commit intocss-modules:masterfrom
rtsao:fix-lint
Conversation
|
Great work @rtsao 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were nearly 100 lint errors, I have fixed them all. Furthermore, I have updated the
.lintrcto properly enforce string quote and parenthesis consistency. I also made it so tests will fail if there are lint problems.Personally, I'm a fan of
"space-in-parens": [2, "never"], but because the project uses spaces in parenthesis,"space-in-parens": [2, "always"]is now enforced. (I'd be happy to switch everything to no spaces in parens if the maintainer wanted to 😉 )I have a diff that addresses #13 but I wanted to fix linting first in a separate PR.
I also have a feeling that eslint was actually misconfigured and semicolons are not desired... in which case I recommend adopting https://github.com/feross/standard. I'd be more than happy to reformat things.
We have plans to use
css-modulesin production so I'm definitely more than willing to assist setup tooling stuff and other chores (code coverage, etc.) to help improve quality across the board.