Skip to content

Bump secret service to 1.1.1#145

Open
purejava wants to merge 1 commit intocryptomator:developfrom
purejava:improve-cryptomator-4175
Open

Bump secret service to 1.1.1#145
purejava wants to merge 1 commit intocryptomator:developfrom
purejava:improve-cryptomator-4175

Conversation

@purejava
Copy link
Contributor

This updates to the latest version of the secret service library.

It now logs a failure due to a missing keychain back end instead of throwing an IllegalStateException.

Besides that, contained libraries were updated.

@coderabbitai
Copy link

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5bc08bd4-4f86-4a40-9574-7dbdd9b8cb0e

📥 Commits

Reviewing files that changed from the base of the PR and between 53e098f and ab4844f.

📒 Files selected for processing (1)
  • pom.xml

Walkthrough

The pull request updates the secret-service-02.version Maven property in pom.xml from version 1.1.0 to 1.1.1. This change updates the resolved version of the org.purejava:secret-service runtime dependency that is referenced via this property. No additional logic, configuration, or control-flow changes are introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • New secret service #125: Added the initial org.purejava:secret-service dependency and property that is now being version-bumped in this PR.

Suggested labels

dependencies

Suggested reviewers

  • overheadhunter
  • infeo
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately and concisely describes the main change: bumping the secret service dependency from 1.1.0 to 1.1.1.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for the version bump and the behavioral improvements in the new version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant