Merged
Conversation
jimmcgaw
commented
Mar 6, 2023
elimisteve
reviewed
Mar 6, 2023
|
|
||
| const [showQRCode, setShowQRCode] = useState(false); | ||
|
|
||
| const inviteLink = getWindowLocationHref(); |
Member
There was a problem hiding this comment.
@jimmcgaw To avoid race conditions please run getWindowLocationHref() as late as possible. On mobile, the app loads with window.location.href === 'http://www.leapchat.org', with no URL hash
Member
There was a problem hiding this comment.
elimisteve
reviewed
Mar 6, 2023
| <FaQrcode size={15} /> | ||
| </Button> | ||
| <div className="qr-code"> | ||
| {showQRCode && <QRCode value={inviteLink} />} |
Member
There was a problem hiding this comment.
...which is to say: please tweak this to say {showQRCode && <QRCode value={getWindowLocationHref()} />}
Collaborator
Author
There was a problem hiding this comment.
Did it slightly differently, but done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.