Draft
Conversation
- prisma schema naming changes - added typescript eslint parser
- adjusted some typescript and eslint config properties - adjust Prisma data model names
- added yarn build command for building typescript into javascript
lxkedinh
requested changes
Oct 16, 2023
Collaborator
lxkedinh
left a comment
lxkedinh
left a comment
There was a problem hiding this comment.
Really good job so far Michael, there are only a few minor things that need to be changed.
- added ts-node to run typescript directly without having to transpile to js first
- fixed ApiRequest type to default to empty object instead of void to fix type error
- enables API testing since local auth is used in automatic authentication in our Postman - fixed Guild Prisma model not mapping correctly to guilds table in Postgres
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.