Open
Conversation
Darren52BT
requested changes
Apr 23, 2024
Collaborator
Darren52BT
left a comment
There was a problem hiding this comment.
mostly looks good full screen. some issues though;
- the search bar does not match the figma; it should have the corresponding background across both light and dark mode and a magnifying glass as the search button.
- for the footer the CS Central and logo are a little too big, try shrinking them
- the spacing between the links on the right is too much; try shrinking the gaps

-when i shrink the screen the CS Catalog and logo become very large; even larger than it was full screen, please shrink them


there's also some weird spacing going on here that causes everything to be off center
- when the screen shrinks even further the CS Catalog becomes unrecognizable by shrinking, everything is off center, and the socials starting wrapping weirdly. For the socials container try setting it to never wrap.

If you're having trouble trying to modify everything with the current structure you can always refactor the html and stuff. if you have any further questions lmk
Contributor
Author
Darren52BT
requested changes
Apr 27, 2024
Collaborator
There was a problem hiding this comment.
the responsiveness looks a lot better, great job on that.
just a few minor changes;


- if you compare it to the figma, you can see that the font needs to be more compact and smaller, and the socials and their labels need to have more space and the labels need to be smaller in comparison to the socials. additionally it looks like their font weight should be a little stronger.
- the website logos seem to shrink a bit too much when i shrink screen; perhaps you could define a different size or a minimum size.
- additionally it looks low res when the site is fully expanded on my screen. not sure if it's just me or not since my screen is pretty wide, but how did you get the image? you might want to check in with jeff on exporting the icon.

Contributor
Author
|
i have fixed the header and footer, and also added switch for light/dark mode by clicking the light bulb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


update header and footer of the homepage