fix: correct duplicate parameter in signature verification table#617
fix: correct duplicate parameter in signature verification table#617Kropiunig wants to merge 1 commit intocowprotocol:mainfrom
Conversation
Replace duplicate encodeData entry with the missing payload parameter and add its description referencing the PayloadStruct section. Fixes cowprotocol#430
|
@Kropiunig is attempting to deploy a commit to the cow Team on Vercel. A member of the Team first needs to authorize it. |
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation table for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA |
Summary
encodeDataentry in the signature verification parameter tableencodeDatarow with the missingpayloadparameter and added its description linking to thePayloadStructsectionFixes #430
Summary by CodeRabbit
payloadparameter, specifying it contains ABI-encoded Merkle proof and conditional order data.