kola/distros: introduce a rhcos-base variant#4063
Closed
jbtrystram wants to merge 1 commit intocoreos:mainfrom
Closed
kola/distros: introduce a rhcos-base variant#4063jbtrystram wants to merge 1 commit intocoreos:mainfrom
rhcos-base variant#4063jbtrystram wants to merge 1 commit intocoreos:mainfrom
Conversation
As we introduced pure rhel and rhcos variants in [1], we did not change the `name` key in meta.json Kola uses this key to determine the distribution of the image to discriminate relevant tests. Some tests are tied to OCP content, e.g. `crio.base` and `crio.network` [2] and inherently won't work with the base because they rely on content that is added as part of the node image layer. Currently we skip the tests tagged with `openshift` in prow [3] and pipelie to work around this. Going with the principle of least disruption by adding `rhcos-base` rather than adding `rhcos-ocp` because all of the build already out there contains the old name and a I don't want to break compatibility if someone use a newer cosa to test those older builds. [1] openshift/os#1445 [2] https://github.com/coreos/coreos-assembler/blob/main/mantle/kola/tests/crio/crio.go [3] https://github.com/openshift/os/blob/48a18918794f5418352c03a3415fac3fde28e1b6/ci/prow-entrypoint.sh#L306 See openshift/os#1790
Member
Author
|
I did this then realized that we simply do |
Member
|
yeah. I'm not sure if this is the change we'd want to make specifically. Will see what others think. |
Member
|
We discussed this OOB. But just to summarize I think instead what we'll want to do is once we've switched the default variant from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we introduced pure rhel and rhcos variants in [1], we did not change the
namekey in meta.jsonKola uses this key to determine the distribution of the image to discriminate relevant tests.
Some tests are tied to OCP content, e.g.
crio.baseandcrio.network[2] and inherently won't workwith the base because they rely on content that
is added as part of the node image layer.
Currently we skip the tests tagged with
openshiftin prow [3] and pipelie to work around this.Going with the principle of least disruption
by adding
rhcos-baserather than addingrhcos-ocpbecause all of the build already out there contains the old name and a I don't want to break compatibility if someone use a newer cosa to test those olderbuilds.
[1] openshift/os#1445
[2] https://github.com/coreos/coreos-assembler/blob/main/mantle/kola/tests/crio/crio.go
[3] https://github.com/openshift/os/blob/48a18918794f5418352c03a3415fac3fde28e1b6/ci/prow-entrypoint.sh#L306
See openshift/os#1790