cmd/nerdctl: use canonical filenames (e.g., run.go -> container_run.go)#1906
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Jan 23, 2023
Merged
Conversation
AkihiroSuda
force-pushed
the
cmd-canonical-filename
branch
2 times, most recently
from
42ee132 to
ac8b0b9
Compare
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
cmd-canonical-filename
branch
from
ac8b0b9 to
192ed67
Compare
djdongjin
reviewed
Jan 23, 2023
Member
djdongjin
left a comment
djdongjin
left a comment
There was a problem hiding this comment.
we probably should also change cp to copy (cmd/nerdctl/cp.go → cmd/nerdctl/container_copy.go) to be consistent with other filename changes.
Member
Author
No, because |
Member
Author
|
Btw I also noticed that |
djdongjin
approved these changes
Jan 23, 2023
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.