Conversation
vito
changed the title
|
rebased to split the community banner into #411 (though these changes are still on top of it) |
vito
changed the title
no reason in particular, just getting onto a proper tag Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
ended up not using this, but it may be useful in the future Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
pretty sure this fixed weirdness with go 1.16 Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
* switch to GitHub GraphQL API * $GITHUB_TOKEN is now required * fetch top RFCs at build time * cached so it doesn't happen all the time in server mode * show number of open questions for each RFC * sort RFC table by reactions to focus-fire feedback on the most popular RFCs so we can resolve them more quickly Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
prevents word-wrapping, and matches github emoji font size (...i think) Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
* rename local GitHubRelease type so it doesn't look exported
* just don't use a pointer
* skip draft releases, too
* move 'no releases' check to the end (since pre and draft releases
should count as 'no releases')
* ...not that any of this really matters, since we've, like, released
already
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
There was a problem hiding this comment.
Looks good!
Only thing that makes me go 🤨 is the way the number of open question are displayed. On first viewing I thought it was a font error, like it was trying to display an unknown character. I actually only understood what it meant because I have context on the format of RFC's. I don't think this will be obvious to people seeing it for the first time and not being familiar with our RFC format. Maybe @matthewpereira has a better idea of how to represent "number of open questions" in a succinct way? Maybe it should be it's own column called "Open Questions"?
Shouldn't block this pr, but I wanted to discuss it before approving.
|
Excuse the hacky formatting, playing around in the browser, adding open q's as a column |
|
@taylorsilva What happened with the background image at the top there? 😆 And yeah I struggled with the open questions representation for a bit. It had its own column at one point, but I opted to bring it closer to the proposal since it's a sub-heading of it. Here's a cheap attempt that swaps the "?" for an acronym (yay), "OQ":
(Also that's what the header's supposed to look like - does it work for you or was that just a weird screenshot?) |
|
lol yeah firefox messed up the screenshot! it looks fine for me, same as what you're seeing. Gonna approve now, maybe someone will think of something better later. |
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
also update link for submitting feedback (section was renamed) Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
|
Thanks for the review! Just merged the RFC PR, so merging this no. |
3 participants
related to (& dependent on, for some of the links) concourse/rfcs#97
i'd include a screenshot but it's a little janky due to the fixed background image position - try it out with
./scripts/build -s 3000!