add column width to TableCell nodes #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The width is determined by the number of dash and colon characters in the separator line of a table, and passed on to the consumer as an integer. This permits consumers of the AST to render tables that are more proportional the width in the source markdown. No changes have been made to the HTML render to make use of the width information, but the test for this feature demonstrates a possible usage. Should a cell be be created that is further to the right than the parsed separator columns are (i.e., when alignment would be null), then the width will be reported as 0.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
============================================
+ Coverage 94.28% 94.75% +0.46%
- Complexity 227 254 +27
============================================
Files 124 131 +7
Lines 3625 4135 +510
Branches 549 604 +55
============================================
+ Hits 3418 3918 +500
- Misses 104 108 +4
- Partials 103 109 +6
|
robinst
reviewed
Jul 23, 2023
Collaborator
robinst
left a comment
robinst
left a comment
There was a problem hiding this comment.
Just one comment, otherwise looks good to merge!
| } | ||
|
|
||
| /** | ||
| * @return the cell width |
Collaborator
There was a problem hiding this comment.
Can you add a description of what this mean here, similar to the PR description?
Collaborator
|
Released in 0.22.0 now: https://github.com/commonmark/commonmark-java/blob/main/CHANGELOG.md#0220---2024-03-15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra property for column with to
TableCellnodes.The width is determined by the number of dash and colon characters in the separator line of a table, and passed on to the consumer as an integer. This permits consumers of the AST to render tables that are more proportional the width in the source markdown.
No changes have been made to the HTML render to make use of the width information, but the test for this feature demonstrates a possible usage.
Should a cell be created that is further to the right than the parsed separator columns are (i.e., when alignment would be null), then the width will be reported as 0.