TextContentRenderer: How to ignore url in links

[zxy-c]

I want get a plain text of markdown

val parser: Parser = Parser.builder().build()
val document: Node = parser.parse("[Google](https://google.com)")
TextContentRenderer.builder().build().render(document).reader()

The above code will output "" Google \ "(https://google.com)"
How to ignore "(https://google.com)"

[robinst]

Yeah, you can customize rendering like this:

private static class MyLinkRenderer extends AbstractVisitor implements NodeRenderer {
    private final TextContentNodeRendererContext context;

    public MyLinkRenderer(TextContentNodeRendererContext context) {
        this.context = context;
    }

    @Override
    public Set<Class<? extends Node>> getNodeTypes() {
        return Collections.<Class<? extends Node>>singleton(Link.class);
    }

    @Override
    public void render(Node node) {
        renderChildren(node);
    }

    private void renderChildren(Node parent) {
        Node node = parent.getFirstChild();
        while (node != null) {
            Node next = node.getNext();
            context.render(node);
            node = next;
        }
    }
}

public static void main(String[] args) {
    Renderer textRender = TextContentRenderer.builder()
            .nodeRendererFactory(new TextContentNodeRendererFactory() {
                @Override
                public NodeRenderer create(TextContentNodeRendererContext context) {
                    return new MyLinkRenderer(context);
                }
            })
            .build();
    Parser parser = Parser.builder().build();

    String markdown = "[Google](https://google.com)";
    String rendered = textRender.render(parser.parse(markdown));
    System.out.println(rendered);
}

[JacekMTh]

Hi @robinst, This approach doesn't work. Seems like there's a bug in TextContentRenderer.
Constructor adds custom TextContentNodeRendererFactory like this:

this.nodeRendererFactories = new ArrayList<>(builder.nodeRendererFactories.size() + 1);
        this.nodeRendererFactories.addAll(builder.nodeRendererFactories);
        // Add as last. This means clients can override the rendering of core nodes if they want.
        this.nodeRendererFactories.add(new TextContentNodeRendererFactory() {
            @Override
            public NodeRenderer create(TextContentNodeRendererContext context) {
                return new CoreTextContentNodeRenderer(context);
            }
        });

But then RendererContext iterates over nodeRendererFactories starting from the last element:

        private RendererContext(TextContentWriter textContentWriter) {
            this.textContentWriter = textContentWriter;

            // The first node renderer for a node type "wins".
            for (int i = nodeRendererFactories.size() - 1; i >= 0; i--) {
                TextContentNodeRendererFactory nodeRendererFactory = nodeRendererFactories.get(i);
                NodeRenderer nodeRenderer = nodeRendererFactory.create(this);
                nodeRendererMap.add(nodeRenderer);
            }
        }

Therefore CoreTextContentNodeRenderer is always processed as first, and custom NodeRenders are ignored.

[robinst]

@JacekMTh you're right, the logic for TextContentRenderer is wrong there. Fix coming.