chore: to replace fs.access with fs.exist#1890
Conversation
🦋 Changeset detectedLatest commit: 61ead31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 97.76% 97.76%
=======================================
Files 147 147
Lines 4786 4786
Branches 1283 1283
=======================================
Hits 4679 4679
Misses 104 104
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| import CsvParserDiscountCode from './main' | ||
|
|
||
| const doesFileExist = (filePath) => { |
There was a problem hiding this comment.
Just a little observation, it will be nice if we can add a simple unit test to test this function.
There was a problem hiding this comment.
Yes but then we have a cross package dependency. We don't seen to have a shared package so duplication should be fine.
|
Also, to make the testing easier, I will suggest you move |
|
|
||
| import CsvParserDiscountCode from './main' | ||
|
|
||
| const doesFileExist = (filePath) => { |
There was a problem hiding this comment.
Yes but then we have a cross package dependency. We don't seen to have a shared package so duplication should be fine.
f6c38b6 to
61ead31
Compare
* chore: to replace fs.access with fs.exist * chore: changeset --------- Co-authored-by: tdeekens <tobias.deekens@commercetools.com>
Relates to