Skip to content

Optimize auth.js: Replace defaultsDeep with Object.assign #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maslowivan wants to merge 2 commits into from
Closed

Optimize auth.js: Replace defaultsDeep with Object.assign #1649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d31339
Optimize auth.js
maslowivan Jan 24, 2021
3a4788e
Merge branch 'master' into patch-1
ajimae Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/sdk-auth/src/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import type {
UserAuthOptions,
} from 'types/sdk'
import { decode, encode } from 'qss'
import defaultsDeep from 'lodash.defaultsdeep'
import { getErrorByCode } from '@commercetools/sdk-middleware-http'
import * as constants from './constants'

Expand Down Expand Up @@ -237,9 +236,9 @@ export default class SdkAuth {
}

_getRequestConfig(config: CustomAuthOptions = {}): AuthOptions {
const mergedConfig = defaultsDeep({}, config, this.config)
const mergedConfig = Object.assign({}, config, this.config)

// handle scopes array - defaultsDeep would merge arrays together
// handle scopes array - Object.assign would merge arrays together
// instead of taking its first occurrence
if (config.scopes) mergedConfig.scopes = config.scopes

Expand Down