Small markup changes #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexim
approved these changes
Oct 25, 2016
Member
Author
|
Thanks for the review! |
Minoru
reviewed
Oct 25, 2016
| <a href="xmpp:[email protected]?join"> | ||
| <i class="fa-li fa fa-lightbulb-o"></i> XMPP conference | ||
| <a href="https://telegram.me/joinchat/BE1AdEAiwR85TsuRlhU_bA"> | ||
| <i class="fa-li fa fa-envelope-o"></i> Telegram group |
Member
There was a problem hiding this comment.
Sorry, I'm late to the show, but why did you choose fa-envelope over fa-telegram?
Member
Author
There was a problem hiding this comment.
Because I honestly tried to find "telegram" through the search form and it wasn't there.
Member
Author
There was a problem hiding this comment.
But thank you, I'll change the icon in the next release :)
Member
Author
There was a problem hiding this comment.
@Minoru ... and it's not extremely easy to switch to the latest font-awesome version: we need to register on their CDN or upload the font file to our server. I'll file an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44. Closes #49. I have also moved XMPP link closer to the top of the list.