-
Notifications
You must be signed in to change notification settings - Fork 433
Fix ambiguous method invocations and enforce check #4357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ambiguous method invocations and enforce check #4357
Conversation
Qualify method calls with `this` or outer class reference to resolve SpotBugs `IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD` warnings. Update quality report script to enforce this check.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Compared 30 screenshots: 30 matched. Native Android coverage
✅ Native Android screenshot tests passed. Native Android coverage
|
Resolve SpotBugs warnings by explicitly qualifying method calls using `super.` or `Outer.this.` where inner classes inherit methods that shadow outer class methods. Update quality report script to enforce this check.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |







This PR fixes "Potentially ambiguous invocation of either an inherited or outer method" warnings reported by SpotBugs.
It also updates
.github/scripts/generate-quality-report.pyto fail the build if this violation is detected in the future.Affected files:
ComponentSelector.javaToastBar.javaNode.javaUiBinding.javaAutoCompleteTextComponent.javaForm.javaTextComponent.javaPR created automatically by Jules for task 15992235252473212034 started by @shai-almog