Skip to content

Cyclomatic complexity analysis level 1 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahlk merged 3 commits into from
Jan 15, 2025
Merged

Cyclomatic complexity analysis level 1 #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
392d12a
Cyclomatic complexity computation for analysis level 1
sinha108 Jan 13, 2025
ebe64b6
Added catch clause count to computation of cyclomatic complexity for …
sinha108 Jan 13, 2025
83d55e0
Clean up callable declaration string to remove embedded comments.
sinha108 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/main/java/com/ibm/cldk/SymbolTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import com.github.javaparser.ast.body.*;
import com.github.javaparser.ast.expr.*;
import com.github.javaparser.ast.nodeTypes.NodeWithName;
import com.github.javaparser.ast.stmt.BlockStmt;
import com.github.javaparser.ast.stmt.*;
import com.github.javaparser.ast.type.ReferenceType;
import com.github.javaparser.ast.type.Type;
import com.github.javaparser.resolution.declarations.ResolvedMethodDeclaration;
Expand Down Expand Up @@ -273,7 +273,9 @@ private static Pair<String, Callable> processCallableDeclaration(CallableDeclara

// add the complete declaration string, including modifiers, throws, and
// parameter names
callableNode.setDeclaration(callableDecl.getDeclarationAsString(true, true, true).strip());
callableNode.setDeclaration(callableDecl
.getDeclarationAsString(true, true, true)
.strip().replaceAll("//.*\n", ""));

// add information about callable parameters: for each parameter, type, name,
// annotations,
Expand Down Expand Up @@ -301,11 +303,32 @@ private static Pair<String, Callable> processCallableDeclaration(CallableDeclara
callableNode.setAccessedFields(getAccessedFields(body, classFields, typeName));
callableNode.setCallSites(getCallSites(body));
callableNode.setVariableDeclarations(getVariableDeclarations(body));
callableNode.setCyclomaticComplexity(getCyclomaticComplexity(callableDecl));

String callableSignature = (callableDecl instanceof MethodDeclaration) ? callableDecl.getSignature().asString() : callableDecl.getSignature().asString().replace(callableDecl.getSignature().getName(), "<init>");
return Pair.of(callableSignature, callableNode);
}

/**
* Computes cyclomatic complexity for the given callable.
*
* @param callableDeclaration Callable to compute cyclomatic complexity for
* @return cyclomatic complexity
*/
private static int getCyclomaticComplexity(CallableDeclaration callableDeclaration) {
int ifStmtCount = callableDeclaration.findAll(IfStmt.class).size();
int loopStmtCount = callableDeclaration.findAll(DoStmt.class).size() +
callableDeclaration.findAll(ForStmt.class).size() +
callableDeclaration.findAll(ForEachStmt.class).size() +
callableDeclaration.findAll(WhileStmt.class).size();
int switchCaseCount = callableDeclaration.findAll(SwitchStmt.class).stream()
.map(stmt -> stmt.getEntries().size())
.reduce(0, Integer::sum);
int conditionalExprCount = callableDeclaration.findAll(ConditionalExpr.class).size();
int catchClauseCount = callableDeclaration.findAll(CatchClause.class).size();
return ifStmtCount + loopStmtCount + switchCaseCount + conditionalExprCount + catchClauseCount + 1;
}

/**
* Processes the given field declaration to extract information about the
* declared field and
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/com/ibm/cldk/utils/AnalysisUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.ibm.wala.ipa.callgraph.impl.DefaultEntrypoint;
import com.ibm.wala.ipa.cha.IClassHierarchy;
import com.ibm.wala.ssa.IR;
import com.ibm.wala.ssa.ISSABasicBlock;
import com.ibm.wala.ssa.SSAConditionalBranchInstruction;
import com.ibm.wala.ssa.SSASwitchInstruction;
import com.ibm.wala.types.ClassLoaderReference;
Expand Down Expand Up @@ -96,7 +97,11 @@ public static int getCyclomaticComplexity(IR ir) {
int switchBranchCount = Arrays.stream(ir.getInstructions())
.filter(inst -> inst instanceof SSASwitchInstruction)
.map(inst -> ((SSASwitchInstruction) inst).getCasesAndLabels().length).reduce(0, Integer::sum);
return conditionalBranchCount + switchBranchCount + 1;
Iterable<ISSABasicBlock> iterableBasicBlocks = ir::getBlocks;
int catchBlockCount = (int) StreamSupport.stream(iterableBasicBlocks.spliterator(), false)
.filter(ISSABasicBlock::isCatchBlock)
.count();
return conditionalBranchCount + switchBranchCount + catchBlockCount + 1;
}

public static Pair<String, Callable> getCallableFromSymbolTable(IMethod method) {
Expand Down