Merged
Conversation
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Create a dedicated Messages API for user notifications
Create dedicated Messages API
Oct 19, 2025
laeubi
requested changes
Oct 20, 2025
Collaborator
laeubi
left a comment
There was a problem hiding this comment.
@copilot see my review comments here for some changes, additionally we should mark the corresponding method in BuildContext as deprecated with a note to the new API to use.
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/MessageBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
…uctor, copyright removal, create(String message) Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Contributor
Author
Added @deprecated annotations to addMessage and removeMessages methods in BuildContext in commit 6a17a42. |
laeubi
reviewed
Oct 20, 2025
Collaborator
laeubi
left a comment
There was a problem hiding this comment.
@copilot just some smaller remarks
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
…ring() Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
laeubi
approved these changes
Oct 20, 2025
slachiewicz
approved these changes
Oct 20, 2025
slachiewicz
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.codehaus.plexus.build.messagesMessageTypeenum for message severity levels (INFO, WARNING, ERROR)Messageclass to hold message parametersMessageBuilderclass with builder pattern implementationMessagesinterface with clearAll, clear, and build methodsDefaultMessagesimplementation using BuildContextOriginal prompt
Fixes #102
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.