This repository was archived by the owner on Jan 10, 2023. It is now read-only.
open simplecov requirement to 0.21.x#125
Merged
thomasrockhu merged 1 commit intocodecov:masterfrom Jan 14, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 90.52% 91.76% +1.23%
==========================================
Files 1 1
Lines 359 340 -19
==========================================
- Hits 325 312 -13
+ Misses 34 28 -6
Continue to review full report at Codecov.
|
Contributor
Author
|
I missed the discussion in #116. Still, tests don't fail with simplecov 0.21.2. If your parser would fail now, I suggest we need tests here to reflect the requirement. |
AlexWayfer
approved these changes
Jan 13, 2021
thomasrockhu
approved these changes
Jan 14, 2021
|
Thanks @klausbadelt! Excited to have you using Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the latest version of simplecov. 0.21.x was explicitly excluded, but I see no issues and tests pass. Please let me know if I'm missing anything.