This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Fix branch name detection for GitHub Actions CI#111
Merged
thomasrockhu merged 2 commits intocodecov:masterfrom Nov 26, 2020
Merged
Fix branch name detection for GitHub Actions CI#111thomasrockhu merged 2 commits intocodecov:masterfrom
thomasrockhu merged 2 commits intocodecov:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 91.71% 90.52% -1.19%
==========================================
Files 1 1
Lines 338 359 +21
==========================================
+ Hits 310 325 +15
- Misses 28 34 +6
Continue to review full report at Codecov.
|
thomasrockhu
approved these changes
Nov 26, 2020
Contributor
thomasrockhu
left a comment
There was a problem hiding this comment.
Thanks @LocoDelAssembly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two problems, expecting
GITHUB_REFto contain 'head' instead of 'heads' and also not detecting empty string inGITHUB_HEAD_REFas falsey.Without this patch all my commits were considered as being coming from the default branch. I required all fixes to make it work, including GITHUB_HEAD_REF issue as GitHub was providing me an empty string instead of leaving the variable undefined (verified with code below):