-
-
Notifications
You must be signed in to change notification settings - Fork 198
Replace Selenium with Playwright for JavaScript tests #2458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mroderick
wants to merge
11
commits into
codebar:master
Choose a base branch
from
mroderick:use-playwright
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Document complete design for migrating from Selenium to Playwright - Include technical approach, validation plan, and cost-benefit analysis - Add development workflow section to CLAUDE.md specifying PR-only changes
13 task implementation plan with step-by-step instructions: - Dependency updates - Configuration changes - Docker and CI integration - Test validation - Documentation updates
Switch to Playwright for JavaScript browser automation. Provides better debugging tools and improved test stability.
Replace Selenium Chrome driver with Playwright. Supports chromium (default), firefox, and webkit browsers. Headless by default, override with PLAYWRIGHT_HEADLESS=false.
Update test code to work with Playwright driver: - Fix select_from_chosen helper to use JavaScript API instead of native send_keys (Playwright ElementHandle incompatibility) - Update admin members test: change expected subscription count from 0 to -1 (subscription is correctly deleted) - Update manage workshop attendances test: use select_from_chosen helper for Chosen.js dropdown - Replace Selenium window switching with Capybara window_opened_by and within_window for cross-window navigation All 6 JavaScript tests now pass with Playwright driver.
Add Playwright browser installation to Dockerfile. Ensures JavaScript tests work in Docker environment.
Add Playwright installation to bin/dup for initial setup. Ensures new developers have browsers installed.
Add Playwright browser installation to GitHub Actions: - Cache browsers at ~/.cache/ms-playwright (~100MB) - Install browsers and deps on cache miss - Only install system deps on cache hit - Set PLAYWRIGHT_HEADLESS=true for CI runs
Document Playwright as JavaScript driver. Add instructions for debugging and cross-browser testing.
Collaborator
Author
|
Anecdotal benchmarks from running BeforeIntermittent failures AfterNo failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates from Selenium to Playwright for JavaScript browser automation in feature specs.
Changes
selenium-webdriverwithcapybara-playwright-drivergemBenefits
Testing
Developer Impact
PLAYWRIGHT_HEADLESS=falsefor visible debuggingPWDEBUG=1for Playwright Inspectorbin/drspeccontinues to work as before