Fix empty coaches list in workshop feedback + parallel test improvements #2456
+164
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issues with two failing feature tests that were timing-dependent when interacting with Chosen.js select dropdowns. Changes: - Rewrote select_from_chosen helper to use JavaScript instead of simulating clicks - Increased Capybara.default_max_wait_time to 5 seconds for JS tests - Added explicit waits for Chosen dropdown initialization - Used select_from_chosen helper consistently across tests The new approach directly sets select values via JavaScript and triggers Chosen's update events, avoiding race conditions from clicking and typing into the animated dropdown UI. All 777 tests now pass consistently with seed 63863.
Suppress Puma startup messages during test runs to reduce noise and make test output easier to read.
Configure parallel test execution to speed up CI builds and local test runs. ## Changes - Add parallel_tests gem for running tests concurrently - Configure database.yml to support TEST_ENV_NUMBER for parallel databases - Update GitHub Actions workflow to run tests across 4 parallel runners - Configure SimpleCov to merge coverage results from parallel runs ## Local Usage Run tests in parallel with 4 processes: ``` bundle exec parallel_rspec spec/ -n 4 ``` Run with a specific seed: ``` bundle exec parallel_rspec spec/ -n 4 -o '--seed 1234' ``` One-time setup (creates test, test2, test3, test4 databases): ``` bundle exec rake parallel:setup ``` ## Performance Local verification shows 1.84x speedup (162s → 88s) with identical coverage results (95.19%). Expected similar speedup in CI.
Configure SimpleCov to generate unique coverage files for each parallel CI runner and merge them for reporting. Changes: - Detect CI parallel execution via CI_NODE_INDEX environment variable - Generate unique command names (RSpec-0, RSpec-1, etc.) per runner - Preserve resultset files immediately after test completion - Merge all resultsets in separate coverage job before reporting Local parallel execution still works using TEST_ENV_NUMBER detection.
Improves CI speedup from 1.84x to 2.35x based on local testing. Each runner now handles ~17 specs instead of ~26.
Resolves issue where no coaches appeared in the feedback dropdown when students tried to submit workshop feedback. Root cause: The feedback controller was filtering for coaches where attended=true, but attendance is only marked after organizers manually verify it. When feedback emails are sent (the day after workshop), coaches have attending=true but attended=nil. Changes: - Updated set_coaches to use accepted_or_attended scope instead of attended - Added ORDER BY with NULLS LAST to prioritize verified coaches first - Added test for coaches who RSVPd but haven't been verified yet - Added test for verified coaches appearing before unverified coaches This allows students to submit feedback immediately after workshops, even before organizers verify attendance, while still prioritizing verified coaches when that data is available. Fixes codebar#2367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch from this PR has been branched from #2455, please review and merge that one first and then rebase this one.
Summary
This PR includes two major improvements:
1. Fix Issue #2367 - Empty coaches list in workshop feedback form
Problem: When students tried to submit workshop feedback, the coaches dropdown was empty and they couldn't complete the form.
Root Cause: The feedback controller filtered for coaches where
attended=true, but:attended=truewhen organizers manually verify attendanceattending=truebutattended=nilSolution:
accepted_or_attendedscope (includes coaches who either RSVP'd OR had attendance verified)ORDER BY attended DESC NULLS LASTto prioritize verified coaches firstTests Added:
Fixes #2367
Test Results
All tests passing:
Screenshots
Before (Issue #2367)
No coaches in dropdown - user cannot submit feedback
After (Issue #2367)
Coaches appear in dropdown, verified coaches listed first