Skip to content

Conversation

@vmasek
Copy link
Collaborator

@vmasek vmasek commented Oct 18, 2024

closes #776

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 777c86b with source commit b472450.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🟡 50 ↓ −3.5
Updates 🟡 75 🟡 76 ↑ +1.1
Custom checks 🟡 67 🟡 67
Code coverage 🟡 90 🟡 90
Security 🟡 82 🟡 82
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🟡 50 ↓ −3.5
JS Packages NPM outdated dependencies 🟡 75 🟡 76 ↑ +1.1

18 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse First Contentful Paint 🟨 2.9 s 🟥 3.3 s ↑ +13.5 %
Lighthouse Largest Contentful Paint 🟨 2.9 s 🟨 3.3 s ↑ +13.2 %
Lighthouse First Meaningful Paint 🟨 2.9 s 🟨 3.3 s ↑ +13.5 %
JS Packages Outdated NPM dev dependencies. 🟨 56 outdated package versions (32 major, 16 minor, 1 preminor, 6 patch, 1 prerelease) 🟨 49 outdated package versions (27 major, 16 minor, 1 preminor, 4 patch, 1 prerelease) ↓ −12.5 %
Lighthouse Speed Index 🟥 6.7 s 🟥 6.5 s ↓ −2.5 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,814 KiB 🟩 Total size was 1,809 KiB ↓ −0.3 %
Lighthouse Minimizes main-thread work 🟥 20.3 s 🟥 21.5 s ↑ +6 %
Lighthouse Total Blocking Time 🟥 6,890 ms 🟥 7,800 ms ↑ +13.3 %
Lighthouse Max Potential First Input Delay 🟥 3,380 ms 🟥 2,710 ms ↓ −19.7 %
Lighthouse JavaScript execution time 🟥 9.7 s 🟥 10.2 s ↑ +4.6 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↓ −0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 460 ms 🟥 Potential savings of 690 ms ↑ +48.7 %
Lighthouse Initial server response time was short 🟩 Root document took 500 ms 🟩 Root document took 410 ms ↓ −18.5 %
Lighthouse Time to Interactive 🟥 17.1 s 🟥 17.2 s ↑ +0.5 %
Lighthouse Metrics 🟩 100% 🟩 100% ↑ +0.5 %
Lighthouse Server Backend Latencies 🟩 220 ms 🟩 260 ms ↑ +15.2 %
Lighthouse Network Round Trip Times 🟩 70 ms 🟩 80 ms ↑ +16.5 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 70 KiB 🟥 Potential savings of 70 KiB ↑ +3.3 %

495 other audits are unchanged.

@vmasek vmasek enabled auto-merge (rebase) October 18, 2024 07:50
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conventional-changelog-angular package is still installed via indirect dependencies. However, there is no @angular-devkit/build-angular installed.

image

It's not installed on main either, so I'm not sure what the point of this issue was 😅

image

But nice to have Commitlint updated and config converted to ESM.

@vmasek vmasek force-pushed the update-commitlint branch 3 times, most recently from 925005c to 5858cc8 Compare October 18, 2024 08:41
@vmasek vmasek force-pushed the update-commitlint branch from 5858cc8 to ed0f467 Compare October 18, 2024 10:02
@vmasek vmasek merged commit 3465e16 into main Oct 18, 2024
@vmasek vmasek deleted the update-commitlint branch October 18, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce dependencies

3 participants